Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially misleading rebar3 help plugins upgrade doc. #2491

Closed
paulo-ferraz-oliveira opened this issue Feb 7, 2021 · 3 comments · Fixed by #2521
Closed

Potentially misleading rebar3 help plugins upgrade doc. #2491

paulo-ferraz-oliveira opened this issue Feb 7, 2021 · 3 comments · Fixed by #2521

Comments

@paulo-ferraz-oliveira
Copy link
Contributor

The output is

List or upgrade plugins
Usage: rebar3 plugins upgrade [<plugin>]

  <plugin>  Plugin to upgrade

which leads you to believe either a single (or all) plugin(s) can be upgraded (if we take [ and ] to mean "optional"), but that's not the case, since:

rebar3 plugins upgrade           
===> Must give an installed plugin to upgrade as an argument

I don't know which one is in the wrong, here, the code or the doc., but would really like to do rebar3 plugins upgrade and not care about a specific plugin 😄.

@paulo-ferraz-oliveira
Copy link
Contributor Author

I was looking for an issue of this sort, today, and found mine :)

Quick question: is rebar3 plugins upgrade supposed to work for all plugins? Or is the doc. wrong?

@ferd
Copy link
Collaborator

ferd commented Mar 13, 2021

I'd expect both to work, with or without a plugin. Without a plugin would upgrade all of them, and with one named, only that one (and its dependencies) would get upgraded.

@paulo-ferraz-oliveira
Copy link
Contributor Author

"without a plugin" would be nice, since otherwise we need to go around this behaviour and list them or find them (via rebar3 commands). I'll try to eventually find some time to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants