Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve warnings and errors when the dep is a checkout #2334

Closed
tsloughter opened this issue Aug 27, 2020 · 0 comments · Fixed by #2335
Closed

improve warnings and errors when the dep is a checkout #2334

tsloughter opened this issue Aug 27, 2020 · 0 comments · Fixed by #2335

Comments

@tsloughter
Copy link
Collaborator

There are at least two warnings/errors that are confusing messages when the reason for the message is a dep being moved to a checkout:

In rebar_prv_lock if a dep is moved to a checkout it prints the same message as it does if a dep is removed from the config:

%% TODO: don't output this message if the dep is now a checkout
rebar_utils:info_useless(OldLockNames, NewLockNames),

In rebar_prv_upgrade it prints an error if the user attempts to upgrade a dep that doesn't exis:

%% TODO: output a different error if the app is a checkout
?PRV_ERROR({unknown_dependency, Name});

If the dep is instead a checkout it should print an error saying that instead of that it doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant