Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming a spec should rename the function #1189

Closed
michalmuskala opened this issue Feb 2, 2022 · 1 comment · Fixed by #1190
Closed

Renaming a spec should rename the function #1189

michalmuskala opened this issue Feb 2, 2022 · 1 comment · Fixed by #1190
Labels
feature

Comments

@michalmuskala
Copy link
Contributor

michalmuskala commented Feb 2, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Renaming a function works, when the cursor is placed on one of the function heads. The same should work, if the cursor is placed on the spec attached to the function.

Renaming the function already correctly renames the spec.

The attached video shows first attempting to rename a spec. which fails, and then successfully renaming the function.

Screen.Recording.2022-02-02.at.12.51.01.mov
@plux plux mentioned this issue Feb 2, 2022
Merged
@plux
Copy link
Contributor

plux commented Feb 2, 2022

Easy fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support renaming function when standing on spec plux/erlang_ls
2 participants
@plux @michalmuskala