--restrict broken in 3.0.3

[onlyhavecans]

Updating from 3.0.2_1 in brew to 3.0.3 breaks the --restrict option.
The command /usr/local/bin/ponysay --restrict NAME=Rarity --ponyonly no longer shows just Rarity images but any pony.
The changelog shows nothing relating to these changes.

[JotaRandom]

The only changes to the code are the CJK mentioned on the changelog and a few comments on the code dev/test-everything.sh (or was on src) show a even earlier that 3.0.2 "broken" commit from @maandree I will check if i can reproduce and look if at leas i can identify the commit or the cause

[onlyhavecans]

I can verify the following returns a rarity

[I] dos@risuposokon /u/l/C/p/3/bin> pwd
/usr/local/Cellar/ponysay/3.0.2_1/bin
[I] dos@risuposokon /u/l/C/p/3/bin> ./ponysay --restrict NAME=Rarity --ponyonly

but the following does not

[I] dos@risuposokon /u/l/C/p/3/bin> pwd
/usr/local/Cellar/ponysay/3.0.3/bin
[I] dos@risuposokon /u/l/C/p/3/bin> ./ponysay --restrict NAME=Rarity --ponyonly

Installed from brew, macOS Sierra 10.12.6 (16G29), fish version 2.6.0

[JotaRandom]

I don't have time until a weekend so I will try to at least sort the possible commints so for the weekend I can check them, a list is coming

• 45b53d6 working
• Every inmid working
• 86b5dcd fixed Error in manuals/ponysay.texinfo #243 working

From them onward is just readme changes and addition of ponies, nothing touch the code.
I will check during the weekend.

[JotaRandom]

Well this look like goes beyond my initial spectatives.
I tested all from 45b53d6 to 5bcde31 instal installing using --private and all worked perfectly.
Yet using a package manager trigger the issue...

So the problem probably is on the installer ./setup.py on in how ponysay check the files based on what was told during instalation.

[Tonyl314]

An unmatched bracket in a pony's metadata prevented the required pickle file from being created. I made a pull request with a fix.

[matthias4217]

An unmatched bracket in a pony's metadata prevented the required pickle file from being created. I made a pull request with a fix.

Unfortunately, it doesn’t seem to solve the issue for me. I’ve cloned your repo to try it out, and ran python src/__main__.py --restrict NAME=Rarity --ponyonly and python src/__main__.py -o --restrict="coat=white". None of them gave me the expected result. But thanks for your help !

[Tonyl314]

@matthias4217 I believe you have to install through setup.py first, it creates the necessary file for --restrict to work. Could you try that please?

[matthias4217]

Indeed, I’ve spoken too fast. It works fine. However it did work well even before your modifications. To sum up :

• It looks like there were no issues doing manual installs (python setup.py install) or run ponysay by hand (python src/__main__.py --restrict NAME=Rarity --ponyonly). (see Edit)
• Using the ArchLinux packages ponysay or ponysay-git wouldn’t work.
• I’ve changed the repo in my local version of ponysay-git to have @Tonyl314 changes, and installed it (makepkg --install). It works fine !

I’m not well versed in Python packaging, or Archlinux packaging, so I’m not sure why there is this difference in behaviour between package installs and manual ones. I don’t know either how things are on other Linux distributions. I might try it later on Ubuntu. Anyway, thanks a lot for the fix !

Edit : As I had already compiled the metadata file from other tries, I didn’t realize there was an issue. Removing these metadata and retrying on 8a2c714 failed.

[Tonyl314]

I've tried it again, but the current master (without my fix) really doesn't work for me. Have you uninstalled properly via setup.py before testing? Maybe the metadata file survived at /usr/share/ponysay/ponies/metadata.

Here's what I did with the master version:

• sudo python setup.py install --freedom=partial
• ponysay -o --restrict NAME=Rarity (doesn't work)
• ponysay-tool --metadata /usr/share/ponysay/ponies (this is also run during installation; it should raise an exception, a "bracket mismatch")