From a71fb006f427b375315e40a162da6a41d7e99cc0 Mon Sep 17 00:00:00 2001 From: Eric Jelli Date: Wed, 18 Dec 2024 20:30:52 +0100 Subject: [PATCH] ci: Decided not to support depreciated BatchLoader on Windows --- .github/workflows/test_pull_requests.yml | 23 +++++++++++------------ test/test_multicore.py | 1 + 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/test_pull_requests.yml b/.github/workflows/test_pull_requests.yml index 15677034..8db48d3c 100644 --- a/.github/workflows/test_pull_requests.yml +++ b/.github/workflows/test_pull_requests.yml @@ -18,8 +18,7 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - #os: [ubuntu-latest, macos-latest, windows-latest] - os: [ubuntu-latest, macos-latest] + os: [ubuntu-latest, macos-latest, windows-latest] # see supported versions at # https://raw.githubusercontent.com/actions/python-versions/master/versions-manifest.json python-version: ['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'] @@ -36,16 +35,16 @@ jobs: python-version: '3.10' - os: macos-latest python-version: '3.11' - #- os: windows-latest - # python-version: '3.7' - #- os: windows-latest - # python-version: '3.8' - #- os: windows-latest - # python-version: '3.9' - #- os: windows-latest - # python-version: '3.10' - #- os: windows-latest - # python-version: '3.11' + - os: windows-latest + python-version: '3.7' + - os: windows-latest + python-version: '3.8' + - os: windows-latest + python-version: '3.9' + - os: windows-latest + python-version: '3.10' + - os: windows-latest + python-version: '3.11' env: OS: ${{ matrix.os }} PYTHON: ${{ matrix.python-version }} diff --git a/test/test_multicore.py b/test/test_multicore.py index a046f9f3..126553a3 100644 --- a/test/test_multicore.py +++ b/test/test_multicore.py @@ -853,6 +853,7 @@ def _batch_loader_load_func(): # Note that BatchLoader is deprecated +@unittest.skipIf(sys.platform.startswith("win"), "depreciated and hangs") class TestBatchLoader(unittest.TestCase): def setUp(self): reseed()