Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 tests are not running on JS or Native #250

Closed
armanbilge opened this issue Mar 3, 2022 · 2 comments
Closed

Scala 3 tests are not running on JS or Native #250

armanbilge opened this issue Mar 3, 2022 · 2 comments

Comments

@armanbilge
Copy link
Contributor

armanbilge commented Mar 3, 2022

This is because of the %% instead of %%%.

libraryDependencies += "org.scalameta" %% "munit" % "0.7.29" % Test

Actually, at the moment it's impossible to run the tests at all on Native, since the munit support is blocked:

We have a couple options:

  1. Keep the status quo for now, since the %% effectively disables the platform tests anyway (maybe this was intentional? :)
  2. Temporarily drop Native, so we can at least enable tests on JS which is an important platform for the folks at @gemini-hlsw.
@erikerlandson
Copy link
Owner

It's semi-deliberate - I tried %%% and as you say ran into problem with native. I wasn't sure what the cleanest way to proceed was, so I put my head in the sand.

I definitely want to support JS for @cquiroz, so if native is blocked it's reasonable to just not build native for now, although it would be cool to do so in the future.

@armanbilge
Copy link
Contributor Author

Yes, I think it's good to start running tests on JS as soon as possible. I think the JVM and Native platforms are more similar, whereas JS has its own quirks, such as the often surprising all-numbers-are-actually-Double semantics :)

I anticipate the native stuff will become unblocked even within a matter of weeks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants