openssh: Add legacy_dsa variant.

Also adds message regarding test requirements.

Also fixes new "platforms" lint warning.

Closes: https://trac.macports.org/ticket/70319

TESTED:
With +legacy_dsa, accepts "+ssh-rsa,ssh-dss" config options.
Built successfully on OSX 10.4-10.5 ppc, 10.4-10.6 i386, 10.5-12.x
x86_64, and 11.x-14.x arm64.  Included all variants compatible with
available dependencies on the respective platforms, except that
testing of +universal was limited to avoid the need to install
+universal versions of many dependencies.

Author: fhgwright

net/openssh/Portfile

@@ -162,6 +162,11 @@ if {${name} eq ${subport}} {
         }
     }
 
+    pre-test {
+        ui_msg "Tests require a cooperating server named 'somehost'."
+        ui_msg "Failure to connect to it results in a hang."
+    }
+
     variant xauth description {Build with support for xauth} {
         configure.args-replace  --without-xauth \
                                 --with-xauth=${prefix}/bin/xauth
@@ -201,6 +206,12 @@ if {${name} eq ${subport}} {
         depends_lib-append      port:libfido2
     }
 
+    variant legacy_dsa description "Enable legacy DSA support (until 2025)" {
+        configure.args-append  --enable-dsa-keys
+        notes-append "DSA support is scheduled to be removed in early 2025."
+        notes-append "DSA-based keys will need to be replaced by then."
+        notes-append "See: https://www.openbsd.org/openssh/releasenotes.html"
+    }
 
     platform darwin {
         # create link to /usr/include/pam because 'security' was renamed to 'pam'
@@ -251,7 +262,6 @@ if {${name} eq ${subport}} {
 
 subport ssh-copy-id {
     revision            0
-    platforms           any
     supported_archs     noarch
     maintainers         {l2dy @l2dy} openmaintainer
     description         Shell script to install your public key(s) on a remote machine