Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when NavigationActions.Pop through gestures #27

Open
lucasfeliciano opened this issue Jan 21, 2016 · 2 comments
Open

Error when NavigationActions.Pop through gestures #27

lucasfeliciano opened this issue Jan 21, 2016 · 2 comments

Comments

@lucasfeliciano
Copy link

When I call the Pop() method by a click handler or calling manually in my code works.
But when I try to go back using the gestures ( swiping left to right ) this happens:

I don't need this feature now, but I though it was nice to report it

screen shot 2016-01-21 at 18 06 29

@ericvicenti
Copy link
Owner

Ah, its a simple fix. We need to remove the new statement from here: https://github.com/ericvicenti/navigation-rfc/blob/master/CustomComponents/NavigationCard.js#L71

@lucasfeliciano
Copy link
Author

I tried that already, thought the same thing but the still got the error.

I debugged it now and discovered that somewhere the React object it is been overwrited and losing the components added to it by the "ugly hack" ( hahah ).

After I include NavigationActions manually, worked even with the new statment which is something that I don't understand why doesn't throw an error there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants