Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.7 #566

Closed
ericsink opened this issue Nov 9, 2023 · 14 comments
Closed

v2.1.7 #566

ericsink opened this issue Nov 9, 2023 · 14 comments

Comments

@ericsink
Copy link
Owner

ericsink commented Nov 9, 2023

  • New packages with support for SQLite3 Multiple Ciphers, thanks to @bricelam and @utelle
  • Fix for problems with VSTO, thanks to @farzonl
  • Fix for perf-related warning CA1859, thanks to @bricelam
  • Fix for incorrect handling of empty string with Span APIs, thanks to @nil4
  • Add sqlite3_serialize/deserialize, thanks to @Trinitek and @garthmz
  • Add support for linux-musl-s390x, thanks to @uweigand
  • Fix problem with calling conventions on x86, thanks to @filipnavara
@utelle
Copy link
Contributor

utelle commented Nov 10, 2023

Regarding the packages for SQLite3 Multiple Ciphers I have 2 comments/questions:

  1. Please add a proper README to the sqlite3mc packages (something like this README @bricelam and I prepared and which is suited for NuGet.org), not only a short package description. I think it is important to guide users of the new packages a bit.
  2. I see library packages SQLitePCLRaw.lib.e_sqlite3mc.androidand SQLitePCLRaw.lib.e_sqlite3mc.ios, but not SQLitePCLRaw.lib.e_sqlite3mc like for the other variants e_sqlite3 and e_sqlcipher. Is this intentional?

@ericsink
Copy link
Owner Author

SQLitePCLRaw.lib.e_sqlite3mc is present and working okay for me. Where are you seeing its absence?

Perhaps what you are seeing is that that directory is not present under src. I think that's because everything inside that directory is automatically generated, and it never got committed to the repo. In most places, I have been committing generated code to the repo, which is an uncommon and questionable practice.

Nonetheless, SQLitePCLRaw.lib.e_sqlite3mc does seem to get generated and built and it shows up in the resulting nupkgs directory.

@utelle
Copy link
Contributor

utelle commented Nov 10, 2023

SQLitePCLRaw.lib.e_sqlite3mc is present and working okay for me. Where are you seeing its absence?

Perhaps what you are seeing is that that directory is not present under src.

Yes, exactly.

I think that's because everything inside that directory is automatically generated, and it never got committed to the repo. In most places, I have been committing generated code to the repo, which is an uncommon and questionable practice.

Well, it is a bit confusing if some generated sources are in the repo and some not.

Nonetheless, SQLitePCLRaw.lib.e_sqlite3mc does seem to get generated and built and it shows up in the resulting nupkgs directory.

Ok. Thanks for the clarification.

@ericsink
Copy link
Owner Author

I grabbed that README and put it into the bundle_e_sqlite3mc package, which is the same thing that I saw had been done before.

@utelle
Copy link
Contributor

utelle commented Nov 10, 2023

I grabbed that README and put it into the bundle_e_sqlite3mc package, which is the same thing that I saw had been done before.

Thanks. According to @bricelam it should be enough to have the README in the bundle package. Maybe we should remove the version section from the README, because the version information is shown on the NuGet package webpage anyway and will correspond to the actual version number of your package workflow.

@ericsink
Copy link
Owner Author

Maybe we should remove the version section

Done

@utelle
Copy link
Contributor

utelle commented Nov 10, 2023

Maybe we should remove the version section

Done

Sorry, not yet completely. The line in the TOC referring to the version section, should be removed, too. TIA.

@ericsink
Copy link
Owner Author

@bricelam @utelle Do you see anything else that should be done w.r.t. sqlite3mc before I publish a 2.1.7 prerelease?

@bricelam
Copy link
Contributor

LGTM

@utelle
Copy link
Contributor

utelle commented Nov 10, 2023

You may go ahead with the prerelease.

@bricelam
Copy link
Contributor

I think that's because everything inside that directory is automatically generated, and it never got committed to the repo.

Correct. I only included the files I personally authored in the PR to make reviewing easier. I left out the ones generated during build.

@ericsink
Copy link
Owner Author

2.1.7-pre has been published on NuGet.

@bricelam
Copy link
Contributor

Posted More SQLite Encryption in .NET on my blog. I'll also spread the word on social media.

@utelle
Copy link
Contributor

utelle commented Nov 12, 2023

  • In my SQLite3MultipleCiphers-NuGet @bricelam made quite some effort to

    1. Add information about the used versions of SQLite3 Multiple Ciphers and SQLite to the package description automatically
    2. Verify in the test procedure that the corresponding versions were really used

    Is there a way to add this version information to the SQLitePCLRaw packages, too? IMHO it would be useful for users of the packages to easily find out which versions are bundled with the NuGet packages.

  • I opened the package SQLitePCLRaw.bundle_e_sqlite3mc in the NuGet package explorer (see screenshot below) and there are 3 items flagged as missing. However, I don't know how important it is to fix these issue.

grafik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants