Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the header/footer file modular using theme folder #547

Open
stopspazzing opened this issue Jun 4, 2016 · 2 comments
Open

Make the header/footer file modular using theme folder #547

stopspazzing opened this issue Jun 4, 2016 · 2 comments

Comments

@stopspazzing
Copy link
Contributor

stopspazzing commented Jun 4, 2016

I'm still working out the nitty gritty, but adding the ability for people to customize the front-end by making the header/footer file pull "sections" of code from specific locations of a theme would be amazing.

Example as I envision it:
In header footer pull for "head section" from themes folder file name is head.sh

Other file names would be obvious in naming:
body.sh
footer.sh

Should be a javascript folder that gets auto loaded, and same with a css folder. Javascript can and should typically be loaded before closing tag for faster page loading.

So all themes as I envision, would be like this starting from theme folder:

mytheme/js/custom.js
mytheme/css/style.css
mytheme/images/awesome-logo.jpg
mytheme/head.sh
mytheme/header.sh
mytheme/body.sh
mytheme/footer.sh

Both header and footer are located in body, so body.sh calls them. This will make it easier to manage a theme for people. At a minimum head.sh and body.sh would be required.

Also might be nice to be able to override the default .sh files above the theme folder, so a way to do that is to create the same named file in the theme folder and have it parse for it first then fall back to default.

Example:

mytheme/overview.sh would override the default overview.sh.

@stopspazzing
Copy link
Contributor Author

@lantis1008 Was this implemented so I can close this?

@lantis1008
Copy link
Contributor

No it was never done. It seems a bit of a pipe dream to be honest. I can't see huge benefits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants