Update for rust-master: specify mutability of bare pointers, and width of integer literals.

[drbawb]

This fixes two breaking changes from the rust nightlies.

• Integer literals no longer have a default width.
• *T has been removed from the language in favor of *mut T and *const T
  • I've elected to use *const T unless the pointer is passed to a callee which expects an &mut reference

These changes allow me to continue building rust-zmq on the following version of rustc:
rustc 0.11.0-pre (b569c77148e8e839b38b678c7c167efc643d2721 2014-06-29 11:21:39 +0000)
c5e2fe4 tested on rustc 0.11.0-pre (566b57f3de7de80599b052b1a042eef8c9091e7f 2014-06-30 12:16:30 +0000)

[erickt]

Thanks for this! I think you've gotten the pointer conversions incorrect though. According to @alexcrichton, C T* pointers should be converted into Rust *mut T, and const T* to *const T. So can you change:

fn zmq_version(major: *mut c_int, minor: *mut c_int, patch: *mut c_int);
type Context_ = *mut c_void;
type Socket_ = *mut c_void;
...

[drbawb]

Doing that will have rustc complain about the call at lib.rs:257

Inside pub fn version() we're passing immutable references to zmq_version() in the unsafe block at 257.

So we would also have to change the let major; let minor; let patch; to be mutable, and then pass mutable references.

Is that OK?

[erickt]

Oh geeze, that was bad of me. You're fix is the right thing to do.

[erickt]

optval should have a type *const c_void.

[erickt]

other than that fix and cleaning up the later calls to zmq_setsockopt, it looks great. Once you fix it, i'll merge it in. thanks!

[erickt]

Thanks!