[6.0] Fix for downcasting BigInt to Long fails #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslesarenko
requested changes
Jun 12, 2024
sc/shared/src/test/scala/sigmastate/TestingInterpreterSpecification.scala
Show resolved
Hide resolved
Member
Author
|
@aslesarenko comments addressed , please make another pass |
aslesarenko
approved these changes
Jul 24, 2024
Member
aslesarenko
left a comment
aslesarenko
left a comment
There was a problem hiding this comment.
LGTM, but please see the additional comment.
| // Fixed in 6.0 | ||
| assertExceptionThrown( | ||
| SBigInt.upcast(CBigInt(new BigInteger("0", 16)).asInstanceOf[AnyVal]), | ||
| _.getMessage.contains("Cannot upcast value") |
Member
There was a problem hiding this comment.
good enough, but FYI there is also method exceptionLike[ConcreteExectionType]("Cannot upcast value") which tests both exception type and the contents of the message.
Member
Author
There was a problem hiding this comment.
The check is corresponding to previously written code, so such refactoring is a subject of a dedicated issue & PR I suppose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #877
It has test from the issue as well similar ones for all the Numeric types.
Also, Downcast from BigInt to BigInt and Upcast from BigInt to BigInt are fixed now