Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of choices here and elsewhere should be moved into the argument default #512

Closed
seabbs opened this issue Nov 15, 2023 · 1 comment · Fixed by #622
Closed

Use of choices here and elsewhere should be moved into the argument default #512

seabbs opened this issue Nov 15, 2023 · 1 comment · Fixed by #622
Assignees
@sbfnk
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@seabbs
Copy link
Contributor

seabbs commented Nov 15, 2023

EpiNow2/R/summarise.R

Line 802 in 65e6c5a

choices <- c("snapshot", "parameters", "samples")

@seabbs seabbs added enhancement New feature or request good first issue Good for newcomers labels Nov 15, 2023
@sbfnk sbfnk mentioned this issue Feb 14, 2024
Merged
@sbfnk sbfnk moved this to Todo in EpiNow2 v1.5.0 Feb 20, 2024
@sbfnk sbfnk self-assigned this Mar 19, 2024
@sbfnk
Copy link
Contributor

sbfnk commented Mar 19, 2024

Rationale being that this exposes to the user what the options are.

@sbfnk sbfnk mentioned this issue Mar 22, 2024
Merged
7 tasks
@jamesmbaazam jamesmbaazam moved this from Todo to In Progress in EpiNow2 v1.5.0 Mar 22, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in EpiNow2 v1.5.0 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbfnk sbfnk

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
EpiNow2 v1.5.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Default choices epiforecasts/EpiNow2
2 participants
@sbfnk @seabbs