Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safeguards against partial matching #499

Closed
jamesmbaazam opened this issue Nov 1, 2023 · 2 comments · Fixed by #501
Closed

Safeguards against partial matching #499

jamesmbaazam opened this issue Nov 1, 2023 · 2 comments · Fixed by #501

Comments

@jamesmbaazam
Copy link
Contributor

jamesmbaazam commented Nov 1, 2023

Do we want to keep using match.arg or switch to the rlang version which doesn't allow partial matching? This is probably something that requires a new issue but just noting here whilst I think of it.

Originally posted by @seabbs in #476 (comment)

@seabbs
Copy link
Contributor

seabbs commented Nov 6, 2023

I'm very open to switching. It seems like a good idea. There are other nice things in rlang as well so not a massive issue picking up a new dependency (if it is new?)

@jamesmbaazam
Copy link
Contributor Author

Great. rlang is already being imported here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants