Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting templates and the report package #495

Closed
jamesmbaazam opened this issue Oct 31, 2023 · 4 comments · Fixed by #604
Closed

Reporting templates and the report package #495

jamesmbaazam opened this issue Oct 31, 2023 · 4 comments · Fixed by #604

Comments

@jamesmbaazam
Copy link
Contributor

EpiNow2 has reporting templates and are briefly mentioned in the README but there's no guidance on how exactly to use them or whether we even encourage users to use them. I recently came across the report package that provides nice methods for reporting fitted models from the common modelling functions in R like lm, etc, and other well known model objects from the Bayesian world like brms and rstanarm.

I wonder if we could/should upgrade the templates here to methods to work with the S3 classes returned by the various functions, especially after the work in #451, or whether it would be better to contribute reports methods to the {reports} package and link there.

Thoughts?

@seabbs
Copy link
Contributor

seabbs commented Oct 31, 2023

Indeed. So we used these initially for our reporting and as far as I am aware no one else has ever used them.... (that being said its hard to know). I think one option would be just to remove these templates?

The report package looks nice but I am not sure EpiNow2 (despite being amazing) is quite the kind of thing they want to support? As an alternative we could have a support package that contains this new report method perhaps or something similar?

@jamesmbaazam
Copy link
Contributor Author

The report package looks nice but I am not sure EpiNow2 (despite being amazing) is quite the kind of thing they want to support?
I would also imagine how much of a burden it would be to always have to fix issues downstream in reports if the EpiNow2 API changes.

As an alternative we could have a support package that contains this new report method perhaps or something similar?

Yes, like {EpiNow2Extras} 🔥

@seabbs
Copy link
Contributor

seabbs commented Nov 1, 2023

Yes exactly. @sbfnk was interested for a while in making a little package ecosystem and moving things like regional_epinow into their own support package (and perhaps generalising to work better across the model functions). That still seems like a good idea but perhaps relatively time/resource intensive.

In the first instance perhaps we should just drop these templates as we don't really want to support them or at least remove references to them in the README (or in the soon to be getting started guide).

@jamesmbaazam
Copy link
Contributor Author

What was the agreement here? Are we removing the reporting templates and all references to them?

@github-project-automation github-project-automation bot moved this from Todo to Done in EpiNow2 v1.5.0 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants