-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip button in coach body view #265
Comments
Hey @nickbit, thanks for opening a feature request!
I can't think of any other than what you've already suggested.
Yup, I think that would make sense. I'll try do do that before the end of the week. |
Thank you so much Frédéric! |
@ephread any update on that? |
@nickbit yes, sorry I haven't been around for the last six months or so. However, a new parameter in I have a few other things to add, and I'll create a new release. |
Is your feature request related to a problem? Please describe.
I have a design where the skip button is in the body view of the coach marks.
However, when the skip button is clicked, I cannot call
coachMarksController.stop(immediately: true)
with an additionalisSkipped
argument, so theCoachMarksControllerDelegate
gets always false infunc coachMarksController(_ coachMarksController: CoachMarksController, didEndShowingBySkipping skipped: Bool)
Describe the solution you'd like
Is it possible to enhance the stop function with an additional
isSkipped
argument for such cases?Or is there any other workaround in the library?
Describe alternatives you've considered
I can temporarily solve the problem with an
isSkipped
variable in the view controller classes.The text was updated successfully, but these errors were encountered: