Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay.blurEffectStyle not working #229

Closed
ciathyza opened this issue Jan 24, 2020 · 8 comments
Closed

overlay.blurEffectStyle not working #229

ciathyza opened this issue Jan 24, 2020 · 8 comments
Labels

Comments

@ciathyza
Copy link

I'm trying to add a blur effect to the coachMarksController but it doesn't work, e.g.:

_coachMarksController.overlay.blurEffectStyle = .prominent

Results in the background overlay not showing at all and only the text is visible but misplaced on the screen. Any ideas why this wouldn't work?

@ephread
Copy link
Owner

ephread commented Mar 17, 2020

Hey @ciathyza, I don't really know, I can't reproduce the issue. Is it happening as well if you run the example project on your setup?

@ephread
Copy link
Owner

ephread commented Mar 31, 2020

Indirectly related to #231, the issue happens when using a Scene Delegate.

--- Edit ---
My bad, I deleted a line while fixing #231. I still can't reproduce, seem to work on iPhone and iPad for both iOS 12 and 13.

@ephread
Copy link
Owner

ephread commented Jul 16, 2020

@ciathyza is this still happening in the latest version (2.0.0)?

@chamitha
Copy link

chamitha commented Jul 30, 2020

@ephread I'm seeing this issue too in v2.0.0. All is well without setting the blurEffectStyle.
When set nothing is displayed, not even the coachmark.

@ephread
Copy link
Owner

ephread commented Aug 1, 2020

@chamitha does that happen with the example project? On which device/simulator? Do you have a minimal projects to share? I'd really like to get to the bottom of this, but I've been unable to reproduce the issue so far. Maybe I'm missing something obvious here.

@chamitha
Copy link

chamitha commented Aug 2, 2020

@ephread It seems like the issue occurs if the CoachMarksController is started in the context of the view controller. However starting it in the context of the window as per the Readme works fine. Let me know if you need further info or a sample project.

        // This works :)
        coachMarksController.start(in: .window(over: self))

        // This does not work :(
        coachMarksController.start(in: .viewController(self))

@chamitha
Copy link

chamitha commented Aug 2, 2020

and for the record I'm using Xcode 11.6 running the iPhone 11 simulator with iOS 13.6

@ephread
Copy link
Owner

ephread commented Aug 3, 2020

It seems like the issue occurs if the CoachMarksController is started in the context of the view controller. However starting it in the context of the window as per the Readme works fine. Let me know if you need further info or a sample project.

That's an interesting behaviour, thanks for the helping hand @chamitha, it's much appreciated! I'll investigate as soon as possible.

@ephread ephread added the bug label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants