Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coachmarksplaced behind notch in landscape app on iphone x. #205

Closed
kallipigous opened this issue Apr 30, 2019 · 4 comments
Closed

Coachmarksplaced behind notch in landscape app on iphone x. #205

kallipigous opened this issue Apr 30, 2019 · 4 comments

Comments

@kallipigous
Copy link

When I use instructions on a landscape app, coachmarks are sometimes place with reference to the whole window not the safe area that takes into account the notch.

@ephread
Copy link
Owner

ephread commented May 10, 2019

Hi @kallipigous, would you be able to set up a sample project demonstrating the issue? Perhaps it's related to #169?

@kallipigous
Copy link
Author

kallipigous commented May 11, 2019 via email

@ephread
Copy link
Owner

ephread commented Apr 1, 2020

I was able to reproduce this really old issue a few hours ago. I'll investigate.

@ephread ephread self-assigned this Apr 1, 2020
@ephread ephread closed this as completed in 630551c Apr 1, 2020
@ephread
Copy link
Owner

ephread commented Apr 1, 2020

Sorry it took so long to fix this, I don't really understand how I could miss this in the first place.

@ephread ephread removed their assignment Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants