Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added explicit coach mark tap event in CoachMarksControllerDelegate #185

Merged
merged 1 commit into from
May 25, 2022
Merged

added explicit coach mark tap event in CoachMarksControllerDelegate #185

merged 1 commit into from
May 25, 2022

Conversation

BeetLab
Copy link
Contributor

@BeetLab BeetLab commented Oct 8, 2018

Checklist for this pull request

  • I have read the guidelines for contributing.
  • I have updated README.md, describing the new feature I'm adding (if applicable).
  • I have checked that my code additions did fail neither code linting checks nor unit/UI test.

Description

added explicit coach mark tap event in CoachMarksControllerDelegate

@ephread
Copy link
Owner

ephread commented May 25, 2022

Better late than never, four years later, I'm merging. Thanks for your work!

@ephread ephread changed the base branch from master to main May 25, 2022 17:01
@ephread ephread merged commit ed8a7db into ephread:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeetLab @ephread