Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add previous coach mark functionality #182

Merged
merged 3 commits into from
Jan 28, 2019
Merged

Conversation

robert-cronin
Copy link
Contributor

Checklist for this pull request

  • I have read the guidelines for contributing.
  • I have updated README.md, describing the new feature I'm adding (if applicable).
  • I have checked that my code additions did fail neither code linting checks nor unit/UI test.

Description

As discussed in issue #113, this adds a public showPrevious method to show the previous coach mark.
Code style has been maintained, the two methods were copied as templates from existing methods.

It is just a copy of showNextCoachMark with changes to how the current index is incremented and a check for if the currentIndex passes below 0
Merely a copy of showNext with modification to how the currentIndex is modified for numberToSkip and the call to the internal method
@codecov
Copy link

codecov bot commented Sep 13, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2b35ea9). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #182   +/-   ##
=========================================
  Coverage          ?   80.51%           
=========================================
  Files             ?       32           
  Lines             ?     1966           
  Branches          ?        0           
=========================================
  Hits              ?     1583           
  Misses            ?      383           
  Partials          ?        0
Flag Coverage Δ
#ios 80.51% <0%> (?)
Impacted Files Coverage Δ
...ces/Instructions/Managers/Public/FlowManager.swift 64.73% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b35ea9...f17a4df. Read the comment docs.

@ephread
Copy link
Owner

ephread commented Sep 13, 2018

Awesome, thanks! I’ll take a look when I get back.

@robert-cronin
Copy link
Contributor Author

@ephread are we okay to close this issue? all checks being passed

@ephread
Copy link
Owner

ephread commented Jan 28, 2019

@robert-cronin yes! I totally forgot about the PR, I'm so sorry mate. Thanks for the nudge!

@ephread ephread merged commit 23fb8ad into ephread:master Jan 28, 2019
Tonbouy pushed a commit to Tonbouy/Instructions that referenced this pull request Nov 29, 2019
* Add internal function for showPreviousCoachMark

It is just a copy of showNextCoachMark with changes to how the current index is incremented and a check for if the currentIndex passes below 0

* Create a new public function for showing the previous coach mark

Merely a copy of showNext with modification to how the currentIndex is modified for numberToSkip and the call to the internal method

* Add documentation to explain the new method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants