Add previous coach mark functionality #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is just a copy of showNextCoachMark with changes to how the current index is incremented and a check for if the currentIndex passes below 0
Merely a copy of showNext with modification to how the currentIndex is modified for numberToSkip and the call to the internal method
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
Coverage ? 80.51%
=========================================
Files ? 32
Lines ? 1966
Branches ? 0
=========================================
Hits ? 1583
Misses ? 383
Partials ? 0
Continue to review full report at Codecov.
|
|
Awesome, thanks! I’ll take a look when I get back. |
|
@ephread are we okay to close this issue? all checks being passed |
|
@robert-cronin yes! I totally forgot about the PR, I'm so sorry mate. Thanks for the nudge! |
Tonbouy
pushed a commit
to Tonbouy/Instructions
that referenced
this pull request
Nov 29, 2019
* Add internal function for showPreviousCoachMark It is just a copy of showNextCoachMark with changes to how the current index is incremented and a check for if the currentIndex passes below 0 * Create a new public function for showing the previous coach mark Merely a copy of showNext with modification to how the currentIndex is modified for numberToSkip and the call to the internal method * Add documentation to explain the new method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist for this pull request
Description
As discussed in issue #113, this adds a public showPrevious method to show the previous coach mark.
Code style has been maintained, the two methods were copied as templates from existing methods.