Extract cleanDiacritics from slugify #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esamattis
force-pushed
the
cleanDiacritics
branch
2 times, most recently
from
2703397
to
fc8705e
Compare
esamattis
force-pushed
the
cleanDiacritics
branch
from
fc8705e
to
4124d03
Compare
|
Nice. LGTM |
esamattis
added a commit
that referenced
this pull request
Aug 24, 2015
Extract cleanDiacritics from slugify
|
In the dist/underscore.string.js file cleanDiacritics is not exported. (s.cleanDiacritics is missing) |
This was already fixed in #445 but it was just not released to npm. Just released 3.2.1 to fix this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few times I have needed a custom version of the slugify function and this is the main feature I do not want to reimplement.
For example today I needed a slugify function which preserves dots and removes all other non a-z chars.