Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide dist/underscore.string.min.js in the npm package (again) #402

Merged
merged 1 commit into from
Feb 6, 2015
Merged

provide dist/underscore.string.min.js in the npm package (again) #402

merged 1 commit into from
Feb 6, 2015

Conversation

Mithgol
Copy link
Contributor

@Mithgol Mithgol commented Feb 3, 2015

Browser window's context and Node.js context are different in nw.js and it takes some time to switch between them.

Therefore, when underscore.string is used inside an nwjs-based application, it sometimes makes sense to do both of the following:

  • declare underscore.string as a dependency in package.json (example) and let it be installed with npm install
  • use underscore.string in a browser's window context with <script> (example) instead of (or in addition to) Node.js context with require().

However, the npm package of underscore.string does not currently contain the dist/underscore.string.min.js file that could be installed and referenced by the script element.

That's why this pull request partially reverts c3088d4 (and #193): the minified file dist/underscore.string.min.js is re-added to the npm package. (The larger file dist/underscore.string.js continues to be removed from the package.)

@stoeffel
Copy link
Collaborator

stoeffel commented Feb 3, 2015

This is okay for me.
@epeli ?

@esamattis
Copy link
Owner

Yes. I also think the both dist/underscore.string.min.js and dist/underscore.string.js should be in the package. This is useful when using npm just as a package downloader for AMD for example.

@stoeffel
Copy link
Collaborator

stoeffel commented Feb 4, 2015

@Mithgol could you remove dist completely from .npmignore?

@Mithgol
Copy link
Contributor Author

Mithgol commented Feb 4, 2015

Yep.

@stoeffel
Copy link
Collaborator

stoeffel commented Feb 4, 2015

Could you drop the first unused commit? Thanks

@Mithgol
Copy link
Contributor Author

Mithgol commented Feb 6, 2015

Ok.

stoeffel added a commit that referenced this pull request Feb 6, 2015
provide `dist/underscore.string.min.js` in the npm package (again)
@stoeffel stoeffel merged commit 7d25d2a into esamattis:master Feb 6, 2015
@stoeffel
Copy link
Collaborator

stoeffel commented Feb 6, 2015

Thanks 💯

@Mithgol
Copy link
Contributor Author

Mithgol commented Feb 7, 2015

Could you npm publish a new version? (Thanks in advance.)

@stoeffel
Copy link
Collaborator

stoeffel commented Feb 7, 2015

I will tomorrow. 😄

@stoeffel
Copy link
Collaborator

stoeffel commented Feb 8, 2015

@Mithgol 3.0.3 is released.

Mithgol added a commit to Mithgol/phido that referenced this pull request Feb 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants