Add String.prototype methods to the chain object #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| function prototype2method(methodName) { | ||
| fn2method(methodName, function() { |
There was a problem hiding this comment.
fn2method(methodName, function(context) {
var args = Array.prototype.slice.call(arguments, 1);
|
Two small code style things. But the rest looks good. |
esamattis
force-pushed
the
prototype-methods
branch
from
11b4b3e to
4bd478a
Compare
esamattis
force-pushed
the
prototype-methods
branch
from
4bd478a to
3802005
Compare
esamattis
added a commit
that referenced
this pull request
Jan 15, 2015
Add String.prototype methods to the chain object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #371