From 0e599440db6ab0a5dbd12ac937517dd7a4d2786f Mon Sep 17 00:00:00 2001 From: Ed Page Date: Tue, 17 Oct 2023 15:30:39 -0500 Subject: [PATCH] fix(help): Clarify install's positional - That a version is accepted - That you are selecting from the source a package which led to part of the confusion in #4830 I wonder if we should rename our `CRATE` value names to `PKG`/`PACKAGE` --- src/bin/cargo/commands/install.rs | 3 ++- tests/testsuite/cargo_install/help/stdout.log | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/bin/cargo/commands/install.rs b/src/bin/cargo/commands/install.rs index 6f903479a598..4275aa700757 100644 --- a/src/bin/cargo/commands/install.rs +++ b/src/bin/cargo/commands/install.rs @@ -18,7 +18,8 @@ pub fn cli() -> Command { .about("Install a Rust binary. Default location is $HOME/.cargo/bin") .arg( Arg::new("crate") - .value_name("CRATE") + .value_name("CRATE[@]") + .help("Select the package from the given source") .value_parser(parse_crate) .num_args(0..), ) diff --git a/tests/testsuite/cargo_install/help/stdout.log b/tests/testsuite/cargo_install/help/stdout.log index ebc29bc8dd3d..3a6fe5f824ed 100644 --- a/tests/testsuite/cargo_install/help/stdout.log +++ b/tests/testsuite/cargo_install/help/stdout.log @@ -1,9 +1,9 @@ Install a Rust binary. Default location is $HOME/.cargo/bin -Usage: cargo install [OPTIONS] [CRATE]... +Usage: cargo install [OPTIONS] [CRATE[@]]... Arguments: - [CRATE]... + [CRATE[@]]... Select the package from the given source Options: --version Specify a version to install