diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 485881382..9eabaf0a3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -24,6 +24,8 @@ Both API and implementation stability are important to Nighthawk. Since the API * Generally Nighthawk mirrors [Envoy's policy](https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#pr-review-policy-for-maintainers) with respect to maintainer review policy. * See [OWNERS.md](OWNERS.md) for the current list of maintainers. +* It is helpful if you apply the label `waiting-for-review` to any PRs that are ready to be reviewed by a maintainer. + * Reviewers will change the label to `waiting-for-changes` when responding. # DCO: Sign your work diff --git a/MAINTAINERS.md b/MAINTAINERS.md index bd255c79c..8535ce1a3 100644 --- a/MAINTAINERS.md +++ b/MAINTAINERS.md @@ -18,9 +18,11 @@ Envoy internals. - New features should be added to the [version history](docs/root/version_history.md). - Breaking changes to the [protobuf APIs](api/) are not allowed. - When merging, clean up the commit message so we get a nice history. By default, - github will compile a messages from all the commits that are squashed. + github will compile a message from all the commits that are squashed. The PR title and description should be a good starting point for the final commit message. (If it is not, it may be worth asking the PR author to update the description). +- Make sure that the DCO signoff is included in the final commit message. + - As a convention, it is appropriate to exclude content in the PR description that occurs after the signoff. ## Updates to the Envoy dependency diff --git a/OWNERS.md b/OWNERS.md index d53194152..69b50ca69 100644 --- a/OWNERS.md +++ b/OWNERS.md @@ -13,3 +13,5 @@ routing PRs, questions, etc. to the right place. * Envoy internals and architecture. * Jakub Sobon ([mum4k](https://github.com/mum4k)) (mumak@google.com) * APIs, general functionality and miscellany. +* Nathan Perry ([dubious90](https://github.com/dubious90)) (nbperry@google.com) + * APIs and general functionality. \ No newline at end of file