Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases sync with upstream envoy #1082

Open
Hawksbk opened this issue Jan 9, 2025 · 0 comments
Open

Releases sync with upstream envoy #1082

Hawksbk opened this issue Jan 9, 2025 · 0 comments

Comments

@Hawksbk
Copy link

Hawksbk commented Jan 9, 2025

Hey 👋

I have some kinda confusion with the releases of the go-control-plane, and I'm just hoping that someone may provide me a bit of guidelines about versioning and how to avoid confuses 🙏

We have a control-plane based on this package.

Recently we tried to update the version from 0.13.1 to 0.13.4, and caught by linter information about deprecating the ClusterDNS fields:

[golangci-lint: internal/resource/resource.go#L249](https://github.com/bolteu/bolt-envoy-control-plane/pull/202/files#annotation_30532653468)
SA1019: clstr.DnsRefreshRate is deprecated: Marked as deprecated in envoy/config/cluster/v3/cluster.proto. (staticcheck)

So clstr.DnsRefreshRate was deprecated in favor of extensions.cluster.dns: https://github.com/envoyproxy/envoy/blob/9aaef9877ad5cebbab0dd56a3e99da20b92ab29d/api/envoy/config/cluster/v3/cluster.proto#L956

But, the extensions.cluster.dns is presented only in the main branch of envoy and going to be a part of envoy 1.33 which is pending * https://github.com/envoyproxy/envoy/tree/main/source/extensions/clusters/dns. -> exists

At the same time, when I checked versions of go-control-plane I saw that it's based on envoy 1.32.3:

So overall the question is:

  • Is it supposed to be tagged on a specific version but use main branch of upstream?
  • If no, is there any guidance, on how to get a better understanding of version dependencies between envoy and go-control-plane?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant