From 78d28da7fb870ce4a9fce7e8764c5e5604abf426 Mon Sep 17 00:00:00 2001 From: zirain Date: Thu, 26 Jun 2025 10:16:32 +0800 Subject: [PATCH 1/2] e2e: use appropriate values for upgrade test Signed-off-by: zirain --- .github/workflows/build_and_test.yaml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml index 97dcf1aebd..0ea349f049 100644 --- a/.github/workflows/build_and_test.yaml +++ b/.github/workflows/build_and_test.yaml @@ -136,24 +136,19 @@ jobs: - version: v1.30.10 ipFamily: ipv4 profile: default - loadQPS: 1000 - version: v1.31.6 ipFamily: ipv4 profile: default - loadQPS: 2000 - version: v1.32.3 ipFamily: ipv6 # only run ipv6 test on this version to save time profile: default - loadQPS: 3000 # TODO: this's IPv4 first, need a way to test IPv6 first. - version: v1.33.0 ipFamily: dual # only run dual test on latest version to save time profile: default - loadQPS: 4000 - version: v1.33.0 ipFamily: dual # only run dual test on latest version to save time profile: gateway-namespace-mode - loadQPS: 5000 steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - uses: ./tools/github-actions/setup-deps @@ -177,10 +172,10 @@ jobs: IP_FAMILY: ${{ matrix.target.ipFamily }} KUBE_DEPLOY_PROFILE: ${{ matrix.target.profile }} E2E_TIMEOUT: 1h - # use the loadQPS from the matrix to set the QPS for the E2E tests - # this is used to determine whether the flaky tests are due to load or not - E2E_BACKEND_UPGRADE_QPS: ${{ matrix.target.loadQPS }} - NUM_WORKERS: 2 + # QPS more than 3000 may cause e2e flaky test. + # This is not the limit of Envoy Gateway, + # but the limit of running e2e tests in github CI. + E2E_BACKEND_UPGRADE_QPS: "3000" run: make e2e benchmark-test: From 6be10d4b09e90db46938cf555f02366ec9eb0bd5 Mon Sep 17 00:00:00 2001 From: zirain Date: Thu, 26 Jun 2025 12:05:57 +0800 Subject: [PATCH 2/2] nit Signed-off-by: zirain --- .github/workflows/build_and_test.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/build_and_test.yaml b/.github/workflows/build_and_test.yaml index 0ea349f049..f6256a5a53 100644 --- a/.github/workflows/build_and_test.yaml +++ b/.github/workflows/build_and_test.yaml @@ -172,6 +172,7 @@ jobs: IP_FAMILY: ${{ matrix.target.ipFamily }} KUBE_DEPLOY_PROFILE: ${{ matrix.target.profile }} E2E_TIMEOUT: 1h + NUM_WORKERS: 2 # QPS more than 3000 may cause e2e flaky test. # This is not the limit of Envoy Gateway, # but the limit of running e2e tests in github CI.