From 2c914fe6bbe5b32791e772d46154423cb3cbc641 Mon Sep 17 00:00:00 2001 From: Arko Dasgupta Date: Mon, 17 Mar 2025 12:29:40 -0700 Subject: [PATCH 1/2] bug: dont return an err when gatewayclass is not accepted this is a user generated error, we shouldnt log it as a system error, and return with an error Signed-off-by: Arko Dasgupta --- internal/provider/kubernetes/controller.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/internal/provider/kubernetes/controller.go b/internal/provider/kubernetes/controller.go index 9ed0445fe3..07370f27e0 100644 --- a/internal/provider/kubernetes/controller.go +++ b/internal/provider/kubernetes/controller.go @@ -215,8 +215,7 @@ func (r *gatewayAPIReconciler) Reconcile(ctx context.Context, _ reconcile.Reques string(gwapiv1.GatewayClassReasonInvalidParameters), msg) r.resources.GatewayClassStatuses.Store(utils.NamespacedName(gc), &gc.Status) - r.log.Error(err, "failed to process parametersRef for gatewayclass", "name", managedGC.Name) - return reconcile.Result{}, err + return reconcile.Result{}, nil } } From d645767833b1582cd63fa7e1760b73c2baa856d1 Mon Sep 17 00:00:00 2001 From: Arko Dasgupta Date: Mon, 17 Mar 2025 12:33:23 -0700 Subject: [PATCH 2/2] release notes Signed-off-by: Arko Dasgupta --- release-notes/current.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/release-notes/current.yaml b/release-notes/current.yaml index c995a3e06b..08c25ee2ee 100644 --- a/release-notes/current.yaml +++ b/release-notes/current.yaml @@ -33,6 +33,7 @@ bug fixes: | Fix an issue that stats compressor was not working. Added support for BackendTLSPolicy and EnvoyExtensionPolicy parsing in Standalone mode. Retrigger reconciliation when backendRef of type ServiceImport is updated or when EndpointSlice(s) for a ServiceImport are updated. + Fix not logging an error and returning it in the K8s Reconcile method when a GatewayClass is not accepted. # Enhancements that improve performance. performance improvements: |