Skip to content

Commit d40cdf1

Browse files
committed
chore(examples): fix extensionserver build
Signed-off-by: Maxime Brunet <[email protected]>
1 parent b10f1a2 commit d40cdf1

File tree

5 files changed

+13
-9
lines changed

5 files changed

+13
-9
lines changed

examples/extension-server/Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ APP_NAME ?= extension-server
1010
TAG ?= latest
1111

1212
.PHONY: docker-buildx
13-
docker-buildx:
14-
docker buildx build -f tools/docker/extension-server/Dockerfile . -t $(IMAGE_PREFIX)$(APP_NAME):$(TAG) --build-arg GO_LDFLAGS="$(GO_LDFLAGS)" --load
13+
docker-buildx: build
14+
docker buildx build -f tools/docker/extension-server/Dockerfile . -t $(IMAGE_PREFIX)$(APP_NAME):$(TAG) --load
1515

1616
build: generate manifests
1717
mkdir -p bin

examples/extension-server/charts/extension-server/crds/generated/example.extensions.io_listenercontextexamples.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
33
kind: CustomResourceDefinition
44
metadata:
55
annotations:
6-
controller-gen.kubebuilder.io/version: v0.17.1
6+
controller-gen.kubebuilder.io/version: v0.19.0
77
name: listenercontextexamples.example.extensions.io
88
spec:
99
group: example.extensions.io
@@ -17,7 +17,7 @@ spec:
1717
- name: v1alpha1
1818
schema:
1919
openAPIV3Schema:
20-
description: ListenerContext provides an example extension policy context
20+
description: ListenerContextExample provides an example extension policy context
2121
resource.
2222
properties:
2323
apiVersion:

examples/extension-server/internal/extensionserver/post_cluster_modify.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ func (s *Server) PostClusterModify(ctx context.Context, req *pb.PostClusterModif
5353
s.log.Info("found InferencePool for cluster modification",
5454
slog.String("name", pool.GetName()),
5555
slog.String("namespace", pool.GetNamespace()),
56-
slog.Int("targetPortNumber", int(pool.Spec.TargetPortNumber)))
56+
slog.Any("targetPorts", pool.Spec.TargetPorts))
5757

5858
inferencePoolConfigs = append(inferencePoolConfigs, &pool)
5959
}

examples/extension-server/internal/extensionserver/post_route_modify.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ func (s *Server) PostRouteModify(ctx context.Context, req *pb.PostRouteModifyReq
6262
s.log.Info("found InferencePool backend",
6363
slog.String("name", pool.GetName()),
6464
slog.String("namespace", pool.GetNamespace()),
65-
slog.Int("targetPortNumber", int(pool.Spec.TargetPortNumber)))
65+
slog.Any("targetPorts", pool.Spec.TargetPorts))
6666
break
6767
}
6868
}
@@ -92,7 +92,7 @@ func (s *Server) PostRouteModify(ctx context.Context, req *pb.PostRouteModifyReq
9292
slog.String("route_name", modifiedRoute.GetName()),
9393
slog.String("inference_pool_name", inferencePool.GetName()),
9494
slog.String("inference_pool_namespace", inferencePool.GetNamespace()),
95-
slog.Int("target_port", int(inferencePool.Spec.TargetPortNumber)))
95+
slog.Any("target_ports", inferencePool.Spec.TargetPorts))
9696

9797
return &pb.PostRouteModifyResponse{
9898
Route: modifiedRoute,

examples/extension-server/internal/extensionserver/server_test.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,9 @@ func TestPostRouteModify_WithInferencePool(t *testing.T) {
3232
"namespace": "default",
3333
},
3434
"spec": map[string]interface{}{
35-
"targetPortNumber": 8000,
35+
"targetPorts": []map[string]interface{}{
36+
{"number": 8000},
37+
},
3638
"selector": map[string]interface{}{
3739
"app": "vllm-llama3-8b-instruct",
3840
},
@@ -188,7 +190,9 @@ func TestPostClusterModify_WithInferencePool(t *testing.T) {
188190
"namespace": "default",
189191
},
190192
"spec": map[string]interface{}{
191-
"targetPortNumber": 8000,
193+
"targetPorts": []map[string]interface{}{
194+
{"number": 8000},
195+
},
192196
"selector": map[string]interface{}{
193197
"app": "vllm-llama3-8b-instruct",
194198
},

0 commit comments

Comments
 (0)