diff --git a/test/extensions/access_loggers/http_grpc/grpc_access_log_integration_test.cc b/test/extensions/access_loggers/http_grpc/grpc_access_log_integration_test.cc index 11119ee7d1d76..c759bdd8856b7 100644 --- a/test/extensions/access_loggers/http_grpc/grpc_access_log_integration_test.cc +++ b/test/extensions/access_loggers/http_grpc/grpc_access_log_integration_test.cc @@ -20,8 +20,7 @@ namespace { class AccessLogIntegrationTest : public Grpc::GrpcClientIntegrationParamTest, public HttpIntegrationTest { public: - AccessLogIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion(), realTime()) {} + AccessLogIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion()) {} void createUpstreams() override { HttpIntegrationTest::createUpstreams(); diff --git a/test/extensions/filters/http/cors/cors_filter_integration_test.cc b/test/extensions/filters/http/cors/cors_filter_integration_test.cc index eba6f92f1cf25..bca2bcff0c630 100644 --- a/test/extensions/filters/http/cors/cors_filter_integration_test.cc +++ b/test/extensions/filters/http/cors/cors_filter_integration_test.cc @@ -9,8 +9,7 @@ namespace Envoy { class CorsFilterIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - CorsFilterIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + CorsFilterIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} void initialize() override { config_helper_.addFilter("name: envoy.cors"); diff --git a/test/extensions/filters/http/grpc_http1_reverse_bridge/reverse_bridge_integration_test.cc b/test/extensions/filters/http/grpc_http1_reverse_bridge/reverse_bridge_integration_test.cc index 00ea8d43efc4b..38783b7ec2376 100644 --- a/test/extensions/filters/http/grpc_http1_reverse_bridge/reverse_bridge_integration_test.cc +++ b/test/extensions/filters/http/grpc_http1_reverse_bridge/reverse_bridge_integration_test.cc @@ -22,7 +22,7 @@ class ReverseBridgeIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - LuaIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + LuaIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} void createUpstreams() override { HttpIntegrationTest::createUpstreams(); diff --git a/test/extensions/filters/http/squash/squash_filter_integration_test.cc b/test/extensions/filters/http/squash/squash_filter_integration_test.cc index adc3ca1645485..ab2ee89f96b77 100644 --- a/test/extensions/filters/http/squash/squash_filter_integration_test.cc +++ b/test/extensions/filters/http/squash/squash_filter_integration_test.cc @@ -19,8 +19,7 @@ namespace Envoy { class SquashFilterIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - SquashFilterIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + SquashFilterIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} ~SquashFilterIntegrationTest() { if (fake_squash_connection_) { diff --git a/test/extensions/filters/http/tap/tap_filter_integration_test.cc b/test/extensions/filters/http/tap/tap_filter_integration_test.cc index bdebc60dadfa6..524451ca9ff99 100644 --- a/test/extensions/filters/http/tap/tap_filter_integration_test.cc +++ b/test/extensions/filters/http/tap/tap_filter_integration_test.cc @@ -18,7 +18,7 @@ class TapIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - EdsIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + EdsIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} // We need to supply the endpoints via EDS to provide health status. Use a // filesystem delivery to simplify test mechanics. diff --git a/test/integration/h1_fuzz.h b/test/integration/h1_fuzz.h index 051f12a53e66e..5fec0263a3f30 100644 --- a/test/integration/h1_fuzz.h +++ b/test/integration/h1_fuzz.h @@ -12,7 +12,7 @@ namespace Envoy { class H1FuzzIntegrationTest : public HttpIntegrationTest { public: H1FuzzIntegrationTest(Network::Address::IpVersion version) - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, version, realTime()) {} + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, version) {} void initialize() override; void replay(const test::integration::CaptureFuzzTestCase&); diff --git a/test/integration/hds_integration_test.cc b/test/integration/hds_integration_test.cc index 622b084532bce..d48813426534d 100644 --- a/test/integration/hds_integration_test.cc +++ b/test/integration/hds_integration_test.cc @@ -16,6 +16,7 @@ #include "test/config/utility.h" #include "test/integration/http_integration.h" #include "test/test_common/network_utility.h" +#include "test/test_common/simulated_time_system.h" #include "gmock/gmock.h" #include "gtest/gtest.h" @@ -24,10 +25,10 @@ namespace Envoy { namespace { class HdsIntegrationTest : public testing::TestWithParam, + public Event::TestUsingSimulatedTime, public HttpIntegrationTest { public: - HdsIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + HdsIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} void createUpstreams() override { fake_upstreams_.emplace_back( diff --git a/test/integration/header_integration_test.cc b/test/integration/header_integration_test.cc index 7bd62eeb687eb..7bbdc273f7d54 100644 --- a/test/integration/header_integration_test.cc +++ b/test/integration/header_integration_test.cc @@ -154,7 +154,7 @@ class HeaderIntegrationTest public HttpIntegrationTest { public: HeaderIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, std::get<0>(GetParam()), realTime()) {} + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, std::get<0>(GetParam())) {} bool routerSuppressEnvoyHeaders() const { return std::get<1>(GetParam()); } diff --git a/test/integration/http2_integration_test.h b/test/integration/http2_integration_test.h index b310fdee4f47c..c910d6e78cbd3 100644 --- a/test/integration/http2_integration_test.h +++ b/test/integration/http2_integration_test.h @@ -8,8 +8,7 @@ namespace Envoy { class Http2IntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - Http2IntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP2, GetParam(), realTime()) {} + Http2IntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP2, GetParam()) {} void SetUp() override { setDownstreamProtocol(Http::CodecClient::Type::HTTP2); } diff --git a/test/integration/http2_upstream_integration_test.h b/test/integration/http2_upstream_integration_test.h index 8c1a1e52264d6..efb55c2227664 100644 --- a/test/integration/http2_upstream_integration_test.h +++ b/test/integration/http2_upstream_integration_test.h @@ -9,7 +9,7 @@ class Http2UpstreamIntegrationTest : public testing::TestWithParam IntegrationCodecClientPtr; */ class HttpIntegrationTest : public BaseIntegrationTest { public: + // TODO(jmarantz): Remove this once + // https://github.com/envoyproxy/envoy-filter-example/pull/69 is reverted. HttpIntegrationTest(Http::CodecClient::Type downstream_protocol, Network::Address::IpVersion version, TestTimeSystemPtr, const std::string& config = ConfigHelper::HTTP_PROXY_CONFIG) : HttpIntegrationTest(downstream_protocol, version, config) {} + HttpIntegrationTest(Http::CodecClient::Type downstream_protocol, Network::Address::IpVersion version, const std::string& config = ConfigHelper::HTTP_PROXY_CONFIG); + HttpIntegrationTest(Http::CodecClient::Type downstream_protocol, const InstanceConstSharedPtrFn& upstream_address_fn, Network::Address::IpVersion version, diff --git a/test/integration/integration.h b/test/integration/integration.h index 7f2456bcf7799..d6d03e98f9a22 100644 --- a/test/integration/integration.h +++ b/test/integration/integration.h @@ -149,6 +149,8 @@ class BaseIntegrationTest : Logger::Loggable { virtual ~BaseIntegrationTest() {} + // TODO(jmarantz): Remove this once + // https://github.com/envoyproxy/envoy-filter-example/pull/69 is reverted. static TestTimeSystemPtr realTime() { return TestTimeSystemPtr(); } // Initialize the basic proto configuration, create fake upstreams, and start Envoy. diff --git a/test/integration/integration_admin_test.cc b/test/integration/integration_admin_test.cc index 5a0360de7b4ca..2ce9f3b73b347 100644 --- a/test/integration/integration_admin_test.cc +++ b/test/integration/integration_admin_test.cc @@ -419,8 +419,7 @@ TEST_P(IntegrationAdminTest, AdminCpuProfilerStart) { class IntegrationAdminIpv4Ipv6Test : public testing::Test, public HttpIntegrationTest { public: IntegrationAdminIpv4Ipv6Test() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, Network::Address::IpVersion::v4, - realTime()) {} + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, Network::Address::IpVersion::v4) {} void initialize() override { config_helper_.addConfigModifier( @@ -451,7 +450,7 @@ TEST_F(IntegrationAdminIpv4Ipv6Test, Ipv4Ipv6Listen) { // restrictions on their names. class StatsMatcherIntegrationTest : public testing::Test, - public Event::SimulatedTimeSystem, + public Event::TestUsingSimulatedTime, public HttpIntegrationTest, public testing::WithParamInterface { public: diff --git a/test/integration/integration_test.h b/test/integration/integration_test.h index f5399c17d0054..a3b86ead3a858 100644 --- a/test/integration/integration_test.h +++ b/test/integration/integration_test.h @@ -9,7 +9,7 @@ namespace Envoy { class IntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - IntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + IntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} }; class UpstreamEndpointIntegrationTest : public testing::TestWithParam, diff --git a/test/integration/load_stats_integration_test.cc b/test/integration/load_stats_integration_test.cc index 6a90a4bae939d..8d722aa94a38a 100644 --- a/test/integration/load_stats_integration_test.cc +++ b/test/integration/load_stats_integration_test.cc @@ -18,8 +18,7 @@ namespace { class LoadStatsIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - LoadStatsIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) { + LoadStatsIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) { // We rely on some fairly specific load balancing picks in this test, so // determinize the schedule. setDeterministic(); diff --git a/test/integration/proxy_proto_integration_test.h b/test/integration/proxy_proto_integration_test.h index b67e1bc3bed13..e936ec2648f94 100644 --- a/test/integration/proxy_proto_integration_test.h +++ b/test/integration/proxy_proto_integration_test.h @@ -12,8 +12,7 @@ namespace Envoy { class ProxyProtoIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - ProxyProtoIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) { + ProxyProtoIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) { config_helper_.addConfigModifier( [&](envoy::config::bootstrap::v2::Bootstrap& bootstrap) -> void { auto* listener = bootstrap.mutable_static_resources()->mutable_listeners(0); diff --git a/test/integration/ratelimit_integration_test.cc b/test/integration/ratelimit_integration_test.cc index 30fdeac58aec2..c5df2d9636ea2 100644 --- a/test/integration/ratelimit_integration_test.cc +++ b/test/integration/ratelimit_integration_test.cc @@ -18,8 +18,7 @@ namespace { class RatelimitIntegrationTest : public Grpc::GrpcClientIntegrationParamTest, public HttpIntegrationTest { public: - RatelimitIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion(), realTime()) {} + RatelimitIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion()) {} void SetUp() override { initialize(); } diff --git a/test/integration/sds_dynamic_integration_test.cc b/test/integration/sds_dynamic_integration_test.cc index 9c6e825d71069..d7508b3339477 100644 --- a/test/integration/sds_dynamic_integration_test.cc +++ b/test/integration/sds_dynamic_integration_test.cc @@ -45,7 +45,7 @@ class SdsDynamicIntegrationBaseTest : public Grpc::GrpcClientIntegrationParamTes public HttpIntegrationTest { public: SdsDynamicIntegrationBaseTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion(), realTime()), + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, ipVersion()), server_cert_("server_cert"), validation_secret_("validation_secret"), client_cert_("client_cert") {} diff --git a/test/integration/sds_static_integration_test.cc b/test/integration/sds_static_integration_test.cc index bdef8bbfa8dcc..dcd1d0814d1ce 100644 --- a/test/integration/sds_static_integration_test.cc +++ b/test/integration/sds_static_integration_test.cc @@ -38,7 +38,7 @@ class SdsStaticDownstreamIntegrationTest public HttpIntegrationTest { public: SdsStaticDownstreamIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam(), realTime()) {} + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, GetParam()) {} void initialize() override { config_helper_.addConfigModifier([](envoy::config::bootstrap::v2::Bootstrap& bootstrap) { @@ -110,7 +110,7 @@ class SdsStaticUpstreamIntegrationTest : public testing::TestWithParam, public BaseIntegrationTest { public: - StatsIntegrationTest() : BaseIntegrationTest(GetParam(), realTime()) {} + StatsIntegrationTest() : BaseIntegrationTest(GetParam()) {} void TearDown() override { test_server_.reset(); diff --git a/test/integration/tcp_conn_pool_integration_test.cc b/test/integration/tcp_conn_pool_integration_test.cc index b958606d7cb37..d662c9b369dcd 100644 --- a/test/integration/tcp_conn_pool_integration_test.cc +++ b/test/integration/tcp_conn_pool_integration_test.cc @@ -115,8 +115,7 @@ class TcpConnPoolIntegrationTest : public testing::TestWithParam, public BaseIntegrationTest { public: - TcpProxyIntegrationTest() - : BaseIntegrationTest(GetParam(), realTime(), ConfigHelper::TCP_PROXY_CONFIG) { + TcpProxyIntegrationTest() : BaseIntegrationTest(GetParam(), ConfigHelper::TCP_PROXY_CONFIG) { enable_half_close_ = true; } diff --git a/test/integration/uds_integration_test.h b/test/integration/uds_integration_test.h index d0cb2555f1f59..d83d88d802427 100644 --- a/test/integration/uds_integration_test.h +++ b/test/integration/uds_integration_test.h @@ -19,7 +19,7 @@ class UdsUpstreamIntegrationTest public HttpIntegrationTest { public: UdsUpstreamIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, std::get<0>(GetParam()), realTime()), + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, std::get<0>(GetParam())), abstract_namespace_(std::get<1>(GetParam())) {} void createUpstreams() override { @@ -50,7 +50,7 @@ class UdsListenerIntegrationTest public HttpIntegrationTest { public: UdsListenerIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, std::get<0>(GetParam()), realTime()), + : HttpIntegrationTest(Http::CodecClient::Type::HTTP1, std::get<0>(GetParam())), abstract_namespace_(std::get<1>(GetParam())) {} void initialize() override; diff --git a/test/integration/xds_integration_test.cc b/test/integration/xds_integration_test.cc index 6303e1b19216d..500397166278e 100644 --- a/test/integration/xds_integration_test.cc +++ b/test/integration/xds_integration_test.cc @@ -10,8 +10,7 @@ namespace { class XdsIntegrationTest : public testing::TestWithParam, public HttpIntegrationTest { public: - XdsIntegrationTest() - : HttpIntegrationTest(Http::CodecClient::Type::HTTP2, GetParam(), realTime()) { + XdsIntegrationTest() : HttpIntegrationTest(Http::CodecClient::Type::HTTP2, GetParam()) { setUpstreamProtocol(FakeHttpConnection::Type::HTTP2); } diff --git a/test/integration/xfcc_integration_test.h b/test/integration/xfcc_integration_test.h index 0cebe800e186a..488ff98aad65d 100644 --- a/test/integration/xfcc_integration_test.h +++ b/test/integration/xfcc_integration_test.h @@ -35,8 +35,7 @@ class XfccIntegrationTest : public testing::TestWithParam(std::chrono::milliseconds(50)), duration)); const MonotonicTime end_time = monotonicTime() + duration; while (true) { diff --git a/test/test_common/simulated_time_system.h b/test/test_common/simulated_time_system.h index ff2533e5fd1d9..f56061020396b 100644 --- a/test/test_common/simulated_time_system.h +++ b/test/test_common/simulated_time_system.h @@ -118,5 +118,16 @@ class SimulatedTimeSystem : public DelegatingTestTimeSystem