Skip to content

Fix run_envoy_docker.sh 'do_ci.sh ' does not work behind proxy#3956

Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
249043822:bugfix001
Jul 26, 2018
Merged

Fix run_envoy_docker.sh 'do_ci.sh ' does not work behind proxy#3956
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
249043822:bugfix001

Conversation

@249043822
Copy link
Contributor

Description: In @io_bazel_rules_go/go/private/go_repository.bzl, it reads os env HTTP_PROXY and HTTPS_PROXY with upper case:
if "HTTP_PROXY" in ctx.os.environ: fetch_repo_env["HTTP_PROXY"] = ctx.os.environ["HTTP_PROXY"] if "HTTPS_PROXY" in ctx.os.environ: fetch_repo_env["HTTPS_PROXY"] = ctx.os.environ["HTTPS_PROXY"]
if set the container env with lower case, @io_bazel_rules_go/go/private/go_repository.bzl will not fetch the proxy, then the packages which will be downloaded by go_repository failed:
ERROR: /build/tmp/_bazel_bazel/436badd4919a15958fa3800a4e21074a/external/io_bazel_rules_go/proto/BUILD.bazel:21:1: no such package '@org_golang_x_net//context': failed to fetch org_golang_x_net: 2018/07/26 02:33:07 unrecognized import path "golang.org/x/net" and referenced by '@io_bazel_rules_go//proto:go_grpc' ERROR: Analysis of target '//src/envoy:envoy' failed; build aborted: no such package '@org_golang_x_net//context': failed to fetch org_golang_x_net: 2018/07/26 02:33:07 unrecognized import path "golang.org/x/net"
when change to upper case, it works fine, will not need git_hack.sh
Risk Level: CI
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue] #2180
[Optional Deprecated:]

Signed-off-by: 张可10140699 <zhang.ke106@zte.com.cn>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Thank you!

@mattklein123 mattklein123 merged commit 5beff99 into envoyproxy:master Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants