From b957cf4e4b258698200b00876321717cd9ba1970 Mon Sep 17 00:00:00 2001 From: Huabing Zhao Date: Fri, 20 Dec 2024 08:51:48 +0000 Subject: [PATCH] fix xff trusted hops Signed-off-by: Huabing Zhao --- source/extensions/http/original_ip_detection/xff/xff.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/extensions/http/original_ip_detection/xff/xff.cc b/source/extensions/http/original_ip_detection/xff/xff.cc index 3c3fdd60dddc7..7540b9dbebc1f 100644 --- a/source/extensions/http/original_ip_detection/xff/xff.cc +++ b/source/extensions/http/original_ip_detection/xff/xff.cc @@ -55,8 +55,8 @@ XffIPDetection::detect(Envoy::Http::OriginalIPDetectionParams& params) { return {ret.address_, ret.allow_trusted_address_checks_, absl::nullopt, skip_xff_append_}; } - auto ret = - Envoy::Http::Utility::getLastAddressFromXFF(params.request_headers, xff_num_trusted_hops_); + auto ret = Envoy::Http::Utility::getLastAddressFromXFF(params.request_headers, + xff_num_trusted_hops_ - 1); return {ret.address_, ret.allow_trusted_address_checks_, absl::nullopt, skip_xff_append_}; }