From b3366ab99ed0bd7bb4898bb9929d39bb41c2a577 Mon Sep 17 00:00:00 2001 From: Yanjun Xiang Date: Thu, 18 Jan 2024 21:49:34 +0000 Subject: [PATCH] Fix a MSAN issue in ext_authz due to max_request_bytes_ change Signed-off-by: Yanjun Xiang --- source/extensions/filters/http/ext_authz/ext_authz.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/source/extensions/filters/http/ext_authz/ext_authz.cc b/source/extensions/filters/http/ext_authz/ext_authz.cc index fe713f7e98e41..f066b034c6934 100644 --- a/source/extensions/filters/http/ext_authz/ext_authz.cc +++ b/source/extensions/filters/http/ext_authz/ext_authz.cc @@ -152,16 +152,16 @@ Http::FilterHeadersStatus Filter::decodeHeaders(Http::RequestHeaderMap& headers, !(end_stream || Http::Utility::isWebSocketUpgradeRequest(headers) || Http::Utility::isH2UpgradeRequest(headers)); + max_request_bytes_ = config_->maxRequestBytes(); if (buffer_data_) { ENVOY_STREAM_LOG(debug, "ext_authz filter is buffering the request", *decoder_callbacks_); allow_partial_message_ = check_settings.has_with_request_body() ? check_settings.with_request_body().allow_partial_message() : config_->allowPartialMessage(); - max_request_bytes_ = check_settings.has_with_request_body() - ? check_settings.with_request_body().max_request_bytes() - : config_->maxRequestBytes(); - + if (check_settings.has_with_request_body()) { + max_request_bytes_ = check_settings.with_request_body().max_request_bytes(); + } if (!allow_partial_message_) { decoder_callbacks_->setDecoderBufferLimit(max_request_bytes_); }