diff --git a/contrib/sip_proxy/filters/network/source/config.cc b/contrib/sip_proxy/filters/network/source/config.cc index 702a7115c7981..1cde844189c8a 100644 --- a/contrib/sip_proxy/filters/network/source/config.cc +++ b/contrib/sip_proxy/filters/network/source/config.cc @@ -58,7 +58,7 @@ Network::FilterFactoryCb SipProxyFilterConfigFactory::createFilterFactoryFromPro */ auto transaction_infos = std::make_shared(); for (auto& cluster : unique_clusters) { - Stats::ScopePtr stats_scope = + Stats::ScopeSharedPtr stats_scope = context.scope().createScope(fmt::format("cluster.{}.sip_cluster", cluster)); auto transaction_info_ptr = std::make_shared( cluster, context.threadLocal(), diff --git a/envoy/server/admin.h b/envoy/server/admin.h index 928b1350f2ffb..4fc6cc7fc3fe8 100644 --- a/envoy/server/admin.h +++ b/envoy/server/admin.h @@ -197,7 +197,7 @@ class Admin { const std::string& address_out_path, Network::Address::InstanceConstSharedPtr address, const Network::Socket::OptionsSharedPtr& socket_options, - Stats::ScopePtr&& listener_scope) PURE; + Stats::ScopeSharedPtr&& listener_scope) PURE; /** * Executes an admin request with the specified query params. Note: this must diff --git a/source/common/tcp_proxy/tcp_proxy.h b/source/common/tcp_proxy/tcp_proxy.h index 1fdca8cb756a9..23c16f85be05a 100644 --- a/source/common/tcp_proxy/tcp_proxy.h +++ b/source/common/tcp_proxy/tcp_proxy.h @@ -195,7 +195,7 @@ class Config { // Hold a Scope for the lifetime of the configuration because connections in // the UpstreamDrainManager can live longer than the listener. - const Stats::ScopePtr stats_scope_; + const Stats::ScopeSharedPtr stats_scope_; const TcpProxyStats stats_; absl::optional idle_timeout_; diff --git a/source/common/upstream/cds_api_impl.h b/source/common/upstream/cds_api_impl.h index 63ca584eb06db..b38c6686c40aa 100644 --- a/source/common/upstream/cds_api_impl.h +++ b/source/common/upstream/cds_api_impl.h @@ -53,7 +53,7 @@ class CdsApiImpl : public CdsApi, CdsApiHelper helper_; ClusterManager& cm_; - Stats::ScopePtr scope_; + Stats::ScopeSharedPtr scope_; Config::SubscriptionPtr subscription_; std::function initialize_callback_; }; diff --git a/source/common/upstream/cluster_factory_impl.cc b/source/common/upstream/cluster_factory_impl.cc index 603fbce06aa83..091c4ef1be248 100644 --- a/source/common/upstream/cluster_factory_impl.cc +++ b/source/common/upstream/cluster_factory_impl.cc @@ -16,8 +16,8 @@ namespace Upstream { namespace { -Stats::ScopePtr generateStatsScope(const envoy::config::cluster::v3::Cluster& config, - Stats::Store& stats) { +Stats::ScopeSharedPtr generateStatsScope(const envoy::config::cluster::v3::Cluster& config, + Stats::Store& stats) { return stats.createScope(fmt::format( "cluster.{}.", config.alt_stat_name().empty() ? config.name() : config.alt_stat_name())); } diff --git a/source/common/upstream/cluster_factory_impl.h b/source/common/upstream/cluster_factory_impl.h index 1ff81b8503285..50a0cfdb4c341 100644 --- a/source/common/upstream/cluster_factory_impl.h +++ b/source/common/upstream/cluster_factory_impl.h @@ -150,7 +150,7 @@ class ClusterFactoryImplBase : public ClusterFactory { virtual std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) PURE; + Stats::ScopeSharedPtr&& stats_scope) PURE; const std::string name_; }; @@ -174,7 +174,7 @@ template class ConfigurableClusterFactoryBase : public Clust std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override { + Stats::ScopeSharedPtr&& stats_scope) override { ProtobufTypes::MessagePtr config = createEmptyConfigProto(); Config::Utility::translateOpaqueConfig(cluster.cluster_type().typed_config(), socket_factory_context.messageValidationVisitor(), @@ -189,7 +189,7 @@ template class ConfigurableClusterFactoryBase : public Clust const envoy::config::cluster::v3::Cluster& cluster, const ConfigProto& proto_config, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) PURE; + Stats::ScopeSharedPtr&& stats_scope) PURE; }; } // namespace Upstream diff --git a/source/common/upstream/eds.cc b/source/common/upstream/eds.cc index 3e6788d565df7..50e9d256c0888 100644 --- a/source/common/upstream/eds.cc +++ b/source/common/upstream/eds.cc @@ -16,7 +16,7 @@ namespace Upstream { EdsClusterImpl::EdsClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api) + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api) : BaseDynamicClusterImpl(cluster, runtime, factory_context, std::move(stats_scope), added_via_api, factory_context.mainThreadDispatcher().timeSource()), Envoy::Config::SubscriptionBase( @@ -378,7 +378,7 @@ std::pair EdsClusterFactory::createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) { + Stats::ScopeSharedPtr&& stats_scope) { if (!cluster.has_eds_cluster_config()) { throw EnvoyException("cannot create an EDS cluster without an EDS config"); } diff --git a/source/common/upstream/eds.h b/source/common/upstream/eds.h index 476e783a32a58..4d25a888f0b06 100644 --- a/source/common/upstream/eds.h +++ b/source/common/upstream/eds.h @@ -32,7 +32,7 @@ class EdsClusterImpl public: EdsClusterImpl(const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api); + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api); // Upstream::Cluster InitializePhase initializePhase() const override { return initialize_phase_; } @@ -115,7 +115,7 @@ class EdsClusterFactory : public ClusterFactoryImplBase { std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override; + Stats::ScopeSharedPtr&& stats_scope) override; }; } // namespace Upstream diff --git a/source/common/upstream/health_discovery_service.cc b/source/common/upstream/health_discovery_service.cc index 2e3df4300be8a..183d2669711ea 100644 --- a/source/common/upstream/health_discovery_service.cc +++ b/source/common/upstream/health_discovery_service.cc @@ -523,7 +523,7 @@ ClusterSharedPtr HdsCluster::create() { return nullptr; } ClusterInfoConstSharedPtr ProdClusterInfoFactory::createClusterInfo(const CreateClusterInfoParams& params) { - Envoy::Stats::ScopePtr scope = + Envoy::Stats::ScopeSharedPtr scope = params.stats_.createScope(fmt::format("cluster.{}.", params.cluster_.name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( diff --git a/source/common/upstream/leds.h b/source/common/upstream/leds.h index a58f31baa0f4d..d3893f5da184e 100644 --- a/source/common/upstream/leds.h +++ b/source/common/upstream/leds.h @@ -65,7 +65,7 @@ class LedsSubscription const LocalInfo::LocalInfo& local_info_; const std::string cluster_name_; // LEDS stats scope must outlive the subscription. - Stats::ScopePtr stats_scope_; + Stats::ScopeSharedPtr stats_scope_; LedsStats stats_; // A map between a LEDS resource name to the LbEndpoint data. LbEndpointsMap endpoints_map_; diff --git a/source/common/upstream/logical_dns_cluster.cc b/source/common/upstream/logical_dns_cluster.cc index 6e34bbb8fab91..54290881a3fe3 100644 --- a/source/common/upstream/logical_dns_cluster.cc +++ b/source/common/upstream/logical_dns_cluster.cc @@ -48,7 +48,7 @@ LogicalDnsCluster::LogicalDnsCluster( const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Network::DnsResolverSharedPtr dns_resolver, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api) + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api) : ClusterImplBase(cluster, runtime, factory_context, std::move(stats_scope), added_via_api, factory_context.mainThreadDispatcher().timeSource()), dns_resolver_(dns_resolver), @@ -182,7 +182,7 @@ std::pair LogicalDnsClusterFactory::createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) { + Stats::ScopeSharedPtr&& stats_scope) { auto selected_dns_resolver = selectDnsResolver(cluster, context); return std::make_pair(std::make_shared( diff --git a/source/common/upstream/logical_dns_cluster.h b/source/common/upstream/logical_dns_cluster.h index 233244d03bbdf..e30942df7e720 100644 --- a/source/common/upstream/logical_dns_cluster.h +++ b/source/common/upstream/logical_dns_cluster.h @@ -36,7 +36,7 @@ class LogicalDnsCluster : public ClusterImplBase { LogicalDnsCluster(const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Network::DnsResolverSharedPtr dns_resolver, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api); + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api); ~LogicalDnsCluster() override; @@ -85,7 +85,7 @@ class LogicalDnsClusterFactory : public ClusterFactoryImplBase { std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override; + Stats::ScopeSharedPtr&& stats_scope) override; }; DECLARE_FACTORY(LogicalDnsClusterFactory); diff --git a/source/common/upstream/maglev_lb.h b/source/common/upstream/maglev_lb.h index d2c4ed58109bd..0d1c6fc5f71e1 100644 --- a/source/common/upstream/maglev_lb.h +++ b/source/common/upstream/maglev_lb.h @@ -99,7 +99,7 @@ class MaglevLoadBalancer : public ThreadAwareLoadBalancerBase, static MaglevLoadBalancerStats generateStats(Stats::Scope& scope); - Stats::ScopePtr scope_; + Stats::ScopeSharedPtr scope_; MaglevLoadBalancerStats stats_; const uint64_t table_size_; const bool use_hostname_for_hashing_; diff --git a/source/common/upstream/od_cds_api_impl.h b/source/common/upstream/od_cds_api_impl.h index 184cc6f5182e3..43f03d7d6db51 100644 --- a/source/common/upstream/od_cds_api_impl.h +++ b/source/common/upstream/od_cds_api_impl.h @@ -87,7 +87,7 @@ class OdCdsApiImpl : public OdCdsApi, CdsApiHelper helper_; ClusterManager& cm_; MissingClusterNotifier& notifier_; - Stats::ScopePtr scope_; + Stats::ScopeSharedPtr scope_; StartStatus status_; absl::flat_hash_set awaiting_names_; Config::SubscriptionPtr subscription_; diff --git a/source/common/upstream/original_dst_cluster.cc b/source/common/upstream/original_dst_cluster.cc index 60776a01cc03a..86194437a8698 100644 --- a/source/common/upstream/original_dst_cluster.cc +++ b/source/common/upstream/original_dst_cluster.cc @@ -109,7 +109,7 @@ OriginalDstCluster::LoadBalancer::requestOverrideHost(LoadBalancerContext* conte OriginalDstCluster::OriginalDstCluster( const envoy::config::cluster::v3::Cluster& config, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api) + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api) : ClusterImplBase(config, runtime, factory_context, std::move(stats_scope), added_via_api, factory_context.mainThreadDispatcher().timeSource()), dispatcher_(factory_context.mainThreadDispatcher()), @@ -194,7 +194,7 @@ std::pair OriginalDstClusterFactory::createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) { + Stats::ScopeSharedPtr&& stats_scope) { if (cluster.lb_policy() != envoy::config::cluster::v3::Cluster::CLUSTER_PROVIDED) { throw EnvoyException( fmt::format("cluster: LB policy {} is not valid for Cluster type {}. Only " diff --git a/source/common/upstream/original_dst_cluster.h b/source/common/upstream/original_dst_cluster.h index b3b0c61c00d19..730e0c09982ba 100644 --- a/source/common/upstream/original_dst_cluster.h +++ b/source/common/upstream/original_dst_cluster.h @@ -31,7 +31,7 @@ class OriginalDstCluster : public ClusterImplBase { public: OriginalDstCluster(const envoy::config::cluster::v3::Cluster& config, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api); + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api); // Upstream::Cluster InitializePhase initializePhase() const override { return InitializePhase::Primary; } @@ -139,7 +139,7 @@ class OriginalDstClusterFactory : public ClusterFactoryImplBase { std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override; + Stats::ScopeSharedPtr&& stats_scope) override; }; } // namespace Upstream diff --git a/source/common/upstream/ring_hash_lb.h b/source/common/upstream/ring_hash_lb.h index 3369a7ba635a1..aa861eb9fb92c 100644 --- a/source/common/upstream/ring_hash_lb.h +++ b/source/common/upstream/ring_hash_lb.h @@ -87,7 +87,7 @@ class RingHashLoadBalancer : public ThreadAwareLoadBalancerBase, static RingHashLoadBalancerStats generateStats(Stats::Scope& scope); - Stats::ScopePtr scope_; + Stats::ScopeSharedPtr scope_; RingHashLoadBalancerStats stats_; static const uint64_t DefaultMinRingSize = 1024; diff --git a/source/common/upstream/static_cluster.cc b/source/common/upstream/static_cluster.cc index b1656fe2ee698..4fdd3f9f7df34 100644 --- a/source/common/upstream/static_cluster.cc +++ b/source/common/upstream/static_cluster.cc @@ -10,7 +10,7 @@ namespace Upstream { StaticClusterImpl::StaticClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api) + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api) : ClusterImplBase(cluster, runtime, factory_context, std::move(stats_scope), added_via_api, factory_context.mainThreadDispatcher().timeSource()), priority_state_manager_( @@ -65,7 +65,7 @@ std::pair StaticClusterFactory::createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) { + Stats::ScopeSharedPtr&& stats_scope) { return std::make_pair( std::make_shared(cluster, context.runtime(), socket_factory_context, std::move(stats_scope), context.addedViaApi()), diff --git a/source/common/upstream/static_cluster.h b/source/common/upstream/static_cluster.h index a6c710ac6aec6..9ad812505aa5f 100644 --- a/source/common/upstream/static_cluster.h +++ b/source/common/upstream/static_cluster.h @@ -16,7 +16,7 @@ class StaticClusterImpl : public ClusterImplBase { public: StaticClusterImpl(const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api); + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api); // Upstream::Cluster InitializePhase initializePhase() const override { return InitializePhase::Primary; } @@ -40,7 +40,7 @@ class StaticClusterFactory : public ClusterFactoryImplBase { std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override; + Stats::ScopeSharedPtr&& stats_scope) override; }; DECLARE_FACTORY(StaticClusterFactory); diff --git a/source/common/upstream/strict_dns_cluster.cc b/source/common/upstream/strict_dns_cluster.cc index d641c31e781d9..2c26424ff6e73 100644 --- a/source/common/upstream/strict_dns_cluster.cc +++ b/source/common/upstream/strict_dns_cluster.cc @@ -12,7 +12,7 @@ StrictDnsClusterImpl::StrictDnsClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Network::DnsResolverSharedPtr dns_resolver, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api) + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api) : BaseDynamicClusterImpl(cluster, runtime, factory_context, std::move(stats_scope), added_via_api, factory_context.mainThreadDispatcher().timeSource()), load_assignment_(cluster.load_assignment()), local_info_(factory_context.localInfo()), @@ -198,7 +198,7 @@ std::pair StrictDnsClusterFactory::createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) { + Stats::ScopeSharedPtr&& stats_scope) { auto selected_dns_resolver = selectDnsResolver(cluster, context); return std::make_pair(std::make_shared( diff --git a/source/common/upstream/strict_dns_cluster.h b/source/common/upstream/strict_dns_cluster.h index 70c3040414524..d04fb5e833180 100644 --- a/source/common/upstream/strict_dns_cluster.h +++ b/source/common/upstream/strict_dns_cluster.h @@ -18,7 +18,7 @@ class StrictDnsClusterImpl : public BaseDynamicClusterImpl { StrictDnsClusterImpl(const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Network::DnsResolverSharedPtr dns_resolver, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api); + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api); // Upstream::Cluster InitializePhase initializePhase() const override { return InitializePhase::Primary; } @@ -83,7 +83,7 @@ class StrictDnsClusterFactory : public ClusterFactoryImplBase { std::pair createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override; + Stats::ScopeSharedPtr&& stats_scope) override; }; } // namespace Upstream diff --git a/source/common/upstream/upstream_impl.cc b/source/common/upstream/upstream_impl.cc index f01a65a00f199..cedb77f32d8ec 100644 --- a/source/common/upstream/upstream_impl.cc +++ b/source/common/upstream/upstream_impl.cc @@ -787,8 +787,8 @@ createOptions(const envoy::config::cluster::v3::Cluster& config, ClusterInfoImpl::ClusterInfoImpl( const envoy::config::cluster::v3::Cluster& config, const envoy::config::core::v3::BindConfig& bind_config, Runtime::Loader& runtime, - TransportSocketMatcherPtr&& socket_matcher, Stats::ScopePtr&& stats_scope, bool added_via_api, - Server::Configuration::TransportSocketFactoryContext& factory_context) + TransportSocketMatcherPtr&& socket_matcher, Stats::ScopeSharedPtr&& stats_scope, + bool added_via_api, Server::Configuration::TransportSocketFactoryContext& factory_context) : runtime_(runtime), name_(config.name()), observability_name_(PROTOBUF_GET_STRING_OR_DEFAULT(config, alt_stat_name, name_)), type_(config.type()), @@ -1067,7 +1067,7 @@ ClusterInfoImpl::upstreamHttpProtocol(absl::optional downstream_ ClusterImplBase::ClusterImplBase( const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api, TimeSource& time_source) + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api, TimeSource& time_source) : init_manager_(fmt::format("Cluster {}", cluster.name())), init_watcher_("ClusterImplBase", [this]() { onInitDone(); }), runtime_(runtime), wait_for_warm_on_init_(PROTOBUF_GET_WRAPPED_OR_DEFAULT(cluster, wait_for_warm_on_init, true)), diff --git a/source/common/upstream/upstream_impl.h b/source/common/upstream/upstream_impl.h index 666e35d441f10..2dc5065a18f5b 100644 --- a/source/common/upstream/upstream_impl.h +++ b/source/common/upstream/upstream_impl.h @@ -606,7 +606,7 @@ class ClusterInfoImpl : public ClusterInfo, Envoy::Extensions::Upstreams::Http::ProtocolOptionsConfigImpl; ClusterInfoImpl(const envoy::config::cluster::v3::Cluster& config, const envoy::config::core::v3::BindConfig& bind_config, Runtime::Loader& runtime, - TransportSocketMatcherPtr&& socket_matcher, Stats::ScopePtr&& stats_scope, + TransportSocketMatcherPtr&& socket_matcher, Stats::ScopeSharedPtr&& stats_scope, bool added_via_api, Server::Configuration::TransportSocketFactoryContext&); static ClusterStats generateStats(Stats::Scope& scope, @@ -804,7 +804,7 @@ class ClusterInfoImpl : public ClusterInfo, const float peekahead_ratio_; const uint32_t per_connection_buffer_limit_bytes_; TransportSocketMatcherPtr socket_matcher_; - Stats::ScopePtr stats_scope_; + Stats::ScopeSharedPtr stats_scope_; mutable ClusterStats stats_; Stats::IsolatedStoreImpl load_report_stats_store_; mutable ClusterLoadReportStats load_report_stats_; @@ -917,7 +917,7 @@ class ClusterImplBase : public Cluster, protected Logger::Loggable createClusterImpl( const envoy::config::cluster::v3::Cluster& cluster, ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override { + Stats::ScopeSharedPtr&& stats_scope) override { return std::make_pair(std::make_shared( cluster, context.runtime(), socket_factory_context, std::move(stats_scope), context.addedViaApi(), 1, "127.0.0.1", 80), diff --git a/test/common/upstream/eds_speed_test.cc b/test/common/upstream/eds_speed_test.cc index e8c2f553697e9..c52dc6e7eca58 100644 --- a/test/common/upstream/eds_speed_test.cc +++ b/test/common/upstream/eds_speed_test.cc @@ -83,7 +83,7 @@ class EdsSpeedTest { void resetCluster(const std::string& yaml_config, Cluster::InitializePhase initialize_phase) { local_info_.node_.mutable_locality()->set_zone("us-east-1a"); eds_cluster_ = parseClusterFromV3Yaml(yaml_config); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", eds_cluster_.alt_stat_name().empty() ? eds_cluster_.name() : eds_cluster_.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( diff --git a/test/common/upstream/eds_test.cc b/test/common/upstream/eds_test.cc index a2d48b454542b..0a1bfcff578fa 100644 --- a/test/common/upstream/eds_test.cc +++ b/test/common/upstream/eds_test.cc @@ -125,7 +125,7 @@ class EdsTest : public testing::Test { void resetCluster(const std::string& yaml_config, Cluster::InitializePhase initialize_phase) { local_info_.node_.mutable_locality()->set_zone("us-east-1a"); eds_cluster_ = parseClusterFromV3Yaml(yaml_config); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", eds_cluster_.alt_stat_name().empty() ? eds_cluster_.name() : eds_cluster_.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( diff --git a/test/common/upstream/hds_test.cc b/test/common/upstream/hds_test.cc index 6478e3819b30b..84efa07d3848e 100644 --- a/test/common/upstream/hds_test.cc +++ b/test/common/upstream/hds_test.cc @@ -581,7 +581,7 @@ TEST_F(HdsTest, TestSocketContext) { EXPECT_CALL(test_factory_, createClusterInfo(_)) .WillRepeatedly(Invoke([&](const ClusterInfoFactory::CreateClusterInfoParams& params) { // Build scope, factory_context as does ProdClusterInfoFactory. - Envoy::Stats::ScopePtr scope = + Envoy::Stats::ScopeSharedPtr scope = params.stats_.createScope(fmt::format("cluster.{}.", params.cluster_.name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( params.admin_, params.ssl_context_manager_, *scope, params.cm_, params.local_info_, @@ -1033,7 +1033,7 @@ TEST_F(HdsTest, TestUpdateSocketContext) { EXPECT_CALL(test_factory_, createClusterInfo(_)) .WillRepeatedly(Invoke([&](const ClusterInfoFactory::CreateClusterInfoParams& params) { // Build scope, factory_context as does ProdClusterInfoFactory. - Envoy::Stats::ScopePtr scope = + Envoy::Stats::ScopeSharedPtr scope = params.stats_.createScope(fmt::format("cluster.{}.", params.cluster_.name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( params.admin_, params.ssl_context_manager_, *scope, params.cm_, params.local_info_, diff --git a/test/common/upstream/leds_test.cc b/test/common/upstream/leds_test.cc index 3fbc524970128..5525ec3c25af6 100644 --- a/test/common/upstream/leds_test.cc +++ b/test/common/upstream/leds_test.cc @@ -156,7 +156,7 @@ class LedsTest : public testing::Test { Ssl::MockContextManager ssl_context_manager_; NiceMock cm_; NiceMock dispatcher_; - Envoy::Stats::ScopePtr cluster_scope_; + Envoy::Stats::ScopeSharedPtr cluster_scope_; LedsSubscriptionPtr leds_subscription_; NiceMock random_; NiceMock runtime_; diff --git a/test/common/upstream/logical_dns_cluster_test.cc b/test/common/upstream/logical_dns_cluster_test.cc index c476d2001793c..385eaa0235205 100644 --- a/test/common/upstream/logical_dns_cluster_test.cc +++ b/test/common/upstream/logical_dns_cluster_test.cc @@ -48,7 +48,7 @@ class LogicalDnsClusterTest : public Event::TestUsingSimulatedTime, public testi resolve_timer_ = new Event::MockTimer(&dispatcher_); NiceMock cm; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_store_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_store_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( diff --git a/test/common/upstream/original_dst_cluster_test.cc b/test/common/upstream/original_dst_cluster_test.cc index 24c5b27695cbf..65a09a20d86f6 100644 --- a/test/common/upstream/original_dst_cluster_test.cc +++ b/test/common/upstream/original_dst_cluster_test.cc @@ -75,7 +75,7 @@ class OriginalDstClusterTest : public Event::TestUsingSimulatedTime, public test void setup(const envoy::config::cluster::v3::Cluster& cluster_config) { NiceMock cm; - Envoy::Stats::ScopePtr scope = stats_store_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_store_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( diff --git a/test/common/upstream/subset_lb_test.cc b/test/common/upstream/subset_lb_test.cc index e7d2d873f8dbc..c9e1fa9b243f8 100644 --- a/test/common/upstream/subset_lb_test.cc +++ b/test/common/upstream/subset_lb_test.cc @@ -481,7 +481,7 @@ class SubsetLoadBalancerTest : public Event::TestUsingSimulatedTime, NiceMock runtime_; NiceMock random_; Stats::IsolatedStoreImpl stats_store_; - Stats::ScopePtr scope_; + Stats::ScopeSharedPtr scope_; ClusterStatNames stat_names_; ClusterStats stats_; PrioritySetImpl local_priority_set_; diff --git a/test/common/upstream/transport_socket_matcher_test.cc b/test/common/upstream/transport_socket_matcher_test.cc index b1ae65848262a..caf1f3a9e8b19 100644 --- a/test/common/upstream/transport_socket_matcher_test.cc +++ b/test/common/upstream/transport_socket_matcher_test.cc @@ -109,7 +109,7 @@ class TransportSocketMatcherTest : public testing::Test { NiceMock mock_factory_context_; Network::TransportSocketFactoryPtr mock_default_factory_; Stats::IsolatedStoreImpl stats_store_; - Stats::ScopePtr stats_scope_; + Stats::ScopeSharedPtr stats_scope_; }; TEST_F(TransportSocketMatcherTest, ReturnDefaultSocketFactoryWhenNoMatch) { diff --git a/test/common/upstream/upstream_impl_test.cc b/test/common/upstream/upstream_impl_test.cc index d821adfaf74c4..949dd3193860e 100644 --- a/test/common/upstream/upstream_impl_test.cc +++ b/test/common/upstream/upstream_impl_test.cc @@ -192,7 +192,7 @@ TEST_P(StrictDnsParamTest, ImmediateResolve) { return nullptr; })); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -226,7 +226,7 @@ TEST_F(StrictDnsClusterImplTest, ZeroHostsIsInializedImmediately) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -261,7 +261,7 @@ TEST_F(StrictDnsClusterImplTest, ZeroHostsHealthChecker) { ResolverData resolver(*dns_resolver_, dispatcher_); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -307,7 +307,7 @@ TEST_F(StrictDnsClusterImplTest, DontWaitForDNSOnInit) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -387,7 +387,7 @@ TEST_F(StrictDnsClusterImplTest, Basic) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -553,7 +553,7 @@ TEST_F(StrictDnsClusterImplTest, HostRemovalActiveHealthSkipped) { ResolverData resolver(*dns_resolver_, dispatcher_); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -614,7 +614,7 @@ TEST_F(StrictDnsClusterImplTest, HostRemovalAfterHcFail) { ResolverData resolver(*dns_resolver_, dispatcher_); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -741,7 +741,7 @@ TEST_F(StrictDnsClusterImplTest, LoadAssignmentBasic) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -979,7 +979,7 @@ TEST_F(StrictDnsClusterImplTest, LoadAssignmentBasicMultiplePriorities) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1095,7 +1095,7 @@ TEST_F(StrictDnsClusterImplTest, CustomResolverFails) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format("cluster.{}.", cluster_config.name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( admin_, ssl_context_manager_, *scope, cm_, local_info_, dispatcher_, stats_, @@ -1130,7 +1130,7 @@ TEST_F(StrictDnsClusterImplTest, FailureRefreshRateBackoffResetsWhenSuccessHappe )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1179,7 +1179,7 @@ TEST_F(StrictDnsClusterImplTest, TtlAsDnsRefreshRate) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1259,7 +1259,7 @@ TEST_F(StrictDnsClusterImplTest, Http2UserDefinedSettingsParametersValidation) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1488,7 +1488,7 @@ TEST_F(StaticClusterImplTest, InitialHosts) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1523,7 +1523,7 @@ TEST_F(StaticClusterImplTest, LoadAssignmentEmptyHostname) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1558,7 +1558,7 @@ TEST_F(StaticClusterImplTest, LoadAssignmentNonEmptyHostname) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1593,7 +1593,7 @@ TEST_F(StaticClusterImplTest, LoadAssignmentNonEmptyHostnameWithHealthChecks) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1646,7 +1646,7 @@ TEST_F(StaticClusterImplTest, LoadAssignmentMultiplePriorities) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1691,7 +1691,7 @@ TEST_F(StaticClusterImplTest, LoadAssignmentLocality) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1737,7 +1737,7 @@ TEST_F(StaticClusterImplTest, LoadAssignmentEdsHealth) { NiceMock cm; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1769,7 +1769,7 @@ TEST_F(StaticClusterImplTest, AltStatName) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1799,7 +1799,7 @@ TEST_F(StaticClusterImplTest, RingHash) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1837,7 +1837,7 @@ TEST_F(StaticClusterImplTest, RoundRobinWithSlowStart) { envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1879,7 +1879,7 @@ TEST_F(StaticClusterImplTest, LeastRequestWithSlowStart) { envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1919,7 +1919,7 @@ TEST_F(StaticClusterImplTest, OutlierDetector) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -1977,7 +1977,7 @@ TEST_F(StaticClusterImplTest, HealthyStat) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2118,7 +2118,7 @@ TEST_F(StaticClusterImplTest, UrlConfig) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2170,7 +2170,7 @@ TEST_F(StaticClusterImplTest, UnsupportedLBType) { EXPECT_THROW_WITH_REGEX( { envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format("cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); @@ -2212,7 +2212,7 @@ TEST_F(StaticClusterImplTest, LoadBalancingPolicyWithLbPolicy) { Registry::InjectFactory registered_factory(factory); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2256,7 +2256,7 @@ TEST_F(StaticClusterImplTest, LoadBalancingPolicyWithOtherLbPolicy) { Registry::InjectFactory registered_factory(factory); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2298,7 +2298,7 @@ TEST_F(StaticClusterImplTest, LoadBalancingPolicyWithoutLbPolicy) { Registry::InjectFactory registered_factory(factory); envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2328,7 +2328,7 @@ TEST_F(StaticClusterImplTest, MalformedHostIP) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2356,7 +2356,7 @@ TEST_F(StaticClusterImplTest, NoHostsTest) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format("cluster.{}.", cluster_config.name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( admin_, ssl_context_manager_, *scope, cm_, local_info_, dispatcher_, stats_, @@ -2375,7 +2375,7 @@ TEST_F(StaticClusterImplTest, SourceAddressPriority) { { // If the cluster manager gets a source address from the bootstrap proto, use it. cm_.bind_config_.mutable_source_address()->set_address("1.2.3.5"); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", config.alt_stat_name().empty() ? config.name() : config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( admin_, ssl_context_manager_, *scope, cm_, local_info_, dispatcher_, stats_, @@ -2388,7 +2388,7 @@ TEST_F(StaticClusterImplTest, SourceAddressPriority) { config.mutable_upstream_bind_config()->mutable_source_address()->set_address(cluster_address); { // Verify source address from cluster config is used when present. - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", config.alt_stat_name().empty() ? config.name() : config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( admin_, ssl_context_manager_, *scope, cm_, local_info_, dispatcher_, stats_, @@ -2400,7 +2400,7 @@ TEST_F(StaticClusterImplTest, SourceAddressPriority) { { // The source address from cluster config takes precedence over one from the bootstrap proto. cm_.bind_config_.mutable_source_address()->set_address("1.2.3.5"); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", config.alt_stat_name().empty() ? config.name() : config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( admin_, ssl_context_manager_, *scope, cm_, local_info_, dispatcher_, stats_, @@ -2424,7 +2424,7 @@ TEST_F(StaticClusterImplTest, LedsUnsupported) { )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2460,7 +2460,7 @@ TEST_F(ClusterImplTest, CloseConnectionsOnHostHealthFailure) { port_value: 443 )EOF"; envoy::config::cluster::v3::Cluster cluster_config = parseClusterFromV3Yaml(yaml); - Envoy::Stats::ScopePtr scope = stats_.createScope(fmt::format( + Envoy::Stats::ScopeSharedPtr scope = stats_.createScope(fmt::format( "cluster.{}.", cluster_config.alt_stat_name().empty() ? cluster_config.name() : cluster_config.alt_stat_name())); Envoy::Server::Configuration::TransportSocketFactoryContextImpl factory_context( @@ -2698,7 +2698,7 @@ class ClusterInfoImplTest : public testing::Test { NiceMock tls_; ReadyWatcher initialized_; envoy::config::cluster::v3::Cluster cluster_config_; - Envoy::Stats::ScopePtr scope_; + Envoy::Stats::ScopeSharedPtr scope_; std::unique_ptr factory_context_; NiceMock validation_visitor_; Api::ApiPtr api_; diff --git a/test/integration/clusters/custom_static_cluster.h b/test/integration/clusters/custom_static_cluster.h index 6daeb9220eda4..ef39b5b19da14 100644 --- a/test/integration/clusters/custom_static_cluster.h +++ b/test/integration/clusters/custom_static_cluster.h @@ -26,7 +26,7 @@ class CustomStaticCluster : public Upstream::ClusterImplBase { public: CustomStaticCluster(const envoy::config::cluster::v3::Cluster& cluster, Runtime::Loader& runtime, Server::Configuration::TransportSocketFactoryContextImpl& factory_context, - Stats::ScopePtr&& stats_scope, bool added_via_api, uint32_t priority, + Stats::ScopeSharedPtr&& stats_scope, bool added_via_api, uint32_t priority, std::string address, uint32_t port) : ClusterImplBase(cluster, runtime, factory_context, std::move(stats_scope), added_via_api, factory_context.mainThreadDispatcher().timeSource()), @@ -63,7 +63,7 @@ class CustomStaticClusterFactoryBase : public Upstream::ConfigurableClusterFacto const test::integration::clusters::CustomStaticConfig& proto_config, Upstream::ClusterFactoryContext& context, Server::Configuration::TransportSocketFactoryContextImpl& socket_factory_context, - Stats::ScopePtr&& stats_scope) override { + Stats::ScopeSharedPtr&& stats_scope) override { auto new_cluster = std::make_shared( cluster, context.runtime(), socket_factory_context, std::move(stats_scope), context.addedViaApi(), proto_config.priority(), proto_config.address(), diff --git a/test/integration/fake_upstream.h b/test/integration/fake_upstream.h index 4353e85a6924a..bf9d4e41b09f1 100644 --- a/test/integration/fake_upstream.h +++ b/test/integration/fake_upstream.h @@ -868,7 +868,7 @@ class FakeUpstream : Logger::Loggable, FakeListener listener_; const Network::FilterChainSharedPtr filter_chain_; std::list received_datagrams_ ABSL_GUARDED_BY(lock_); - Stats::ScopePtr stats_scope_; + Stats::ScopeSharedPtr stats_scope_; Http::Http1::CodecStats::AtomicPtr http1_codec_stats_; Http::Http2::CodecStats::AtomicPtr http2_codec_stats_; Http::Http3::CodecStats::AtomicPtr http3_codec_stats_; diff --git a/test/mocks/server/admin.h b/test/mocks/server/admin.h index d2f96eed5aea4..60e7fe6db8e37 100644 --- a/test/mocks/server/admin.h +++ b/test/mocks/server/admin.h @@ -35,7 +35,7 @@ class MockAdmin : public Admin { const std::string& address_out_path, Network::Address::InstanceConstSharedPtr address, const Network::Socket::OptionsSharedPtr& socket_options, - Stats::ScopePtr&& listener_scope)); + Stats::ScopeSharedPtr&& listener_scope)); MOCK_METHOD(Http::Code, request, (absl::string_view path_and_query, absl::string_view method, Http::ResponseHeaderMap& response_headers, std::string& body)); diff --git a/test/mocks/upstream/cluster_info.h b/test/mocks/upstream/cluster_info.h index 9639c6ade7fd0..b57d98f643856 100644 --- a/test/mocks/upstream/cluster_info.h +++ b/test/mocks/upstream/cluster_info.h @@ -209,7 +209,7 @@ class MockClusterInfo : public ClusterInfo { envoy::config::core::v3::Metadata metadata_; std::unique_ptr typed_metadata_; absl::optional max_stream_duration_; - Stats::ScopePtr stats_scope_; + Stats::ScopeSharedPtr stats_scope_; mutable Http::Http1::CodecStats::AtomicPtr http1_codec_stats_; mutable Http::Http2::CodecStats::AtomicPtr http2_codec_stats_; mutable Http::Http3::CodecStats::AtomicPtr http3_codec_stats_;