From de0dc3f482af1b0d615f22b0e04002588f196082 Mon Sep 17 00:00:00 2001 From: Greg Greenway Date: Tue, 29 Mar 2022 10:09:29 -0700 Subject: [PATCH 1/2] docs: Clarify that RegexMatcher uses a full regex match Signed-off-by: Greg Greenway --- api/envoy/type/matcher/v3/regex.proto | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api/envoy/type/matcher/v3/regex.proto b/api/envoy/type/matcher/v3/regex.proto index 32565995f3790..e392d4e07b6af 100644 --- a/api/envoy/type/matcher/v3/regex.proto +++ b/api/envoy/type/matcher/v3/regex.proto @@ -62,7 +62,8 @@ message RegexMatcher { GoogleRE2 google_re2 = 1 [(validate.rules).message = {required: true}]; } - // The regex match string. The string must be supported by the configured engine. + // The regex match string. The string must be supported by the configured engine. The regex should + // specify a full input match, not a partial match. string regex = 2 [(validate.rules).string = {min_len: 1}]; } From a12dca7762ec2ca2520c752a46bbdd4fa236f96b Mon Sep 17 00:00:00 2001 From: Greg Greenway Date: Wed, 30 Mar 2022 09:42:41 -0700 Subject: [PATCH 2/2] update wording Signed-off-by: Greg Greenway --- api/envoy/type/matcher/v3/regex.proto | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/api/envoy/type/matcher/v3/regex.proto b/api/envoy/type/matcher/v3/regex.proto index e392d4e07b6af..f18bd03e2ba5a 100644 --- a/api/envoy/type/matcher/v3/regex.proto +++ b/api/envoy/type/matcher/v3/regex.proto @@ -62,8 +62,8 @@ message RegexMatcher { GoogleRE2 google_re2 = 1 [(validate.rules).message = {required: true}]; } - // The regex match string. The string must be supported by the configured engine. The regex should - // specify a full input match, not a partial match. + // The regex match string. The string must be supported by the configured engine. The regex is matched + // against the full string, not as a partial match. string regex = 2 [(validate.rules).string = {min_len: 1}]; }