From dc7e6e0ed0df5a6016ccc18f72c6069768a871b7 Mon Sep 17 00:00:00 2001 From: Jose Nino Date: Fri, 5 Nov 2021 14:22:06 -0700 Subject: [PATCH] c-ares dns: add log on failure Signed-off-by: Jose Nino --- source/extensions/network/dns_resolver/cares/dns_impl.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/source/extensions/network/dns_resolver/cares/dns_impl.cc b/source/extensions/network/dns_resolver/cares/dns_impl.cc index 38650568adce3..5b12a65a63613 100644 --- a/source/extensions/network/dns_resolver/cares/dns_impl.cc +++ b/source/extensions/network/dns_resolver/cares/dns_impl.cc @@ -100,6 +100,11 @@ void DnsResolverImpl::initializeChannel(ares_options* options, int optmask) { void DnsResolverImpl::PendingResolution::onAresGetAddrInfoCallback(int status, int timeouts, ares_addrinfo* addrinfo) { + if (status != ARES_SUCCESS) { + ENVOY_LOG_EVENT(debug, "cares_resolution_failure", + "dns resolution for {} failed with c-ares status {}", dns_name_, status); + } + // We receive ARES_EDESTRUCTION when destructing with pending queries. if (status == ARES_EDESTRUCTION) { ASSERT(owned_);