From 2b150d8fddcc0d6bbad822d5f6794b747d4de1ec Mon Sep 17 00:00:00 2001 From: Takeshi Yoneda Date: Thu, 21 Oct 2021 13:28:00 +0900 Subject: [PATCH 1/4] Remove redundant Warn log in HTTP codec. (#18699) This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to #18643. Signed-off-by: Takeshi Yoneda Signed-off-by: Abhay Narayan Katare --- source/common/http/codec_client.cc | 3 --- 1 file changed, 3 deletions(-) diff --git a/source/common/http/codec_client.cc b/source/common/http/codec_client.cc index e2d242f543265..29aa601384a44 100644 --- a/source/common/http/codec_client.cc +++ b/source/common/http/codec_client.cc @@ -117,9 +117,6 @@ void CodecClient::onEvent(Network::ConnectionEvent event) { StreamInfo::ResponseFlag::UpstreamProtocolError); } } - } else { - ENVOY_CONN_LOG(warn, "Connection is closed by {} during connecting.", *connection_, - (event == Network::ConnectionEvent::RemoteClose ? "peer" : "self")); } while (!active_requests_.empty()) { // Fake resetting all active streams so that reset() callbacks get invoked. From b736090f1e50ee387e3214e1f4243ff139f1ca93 Mon Sep 17 00:00:00 2001 From: Abhay Narayan Katare Date: Wed, 27 Oct 2021 16:28:26 +0530 Subject: [PATCH 2/4] Adding release note for PR #18702 Signed-off-by: Abhay Narayan Katare --- docs/root/version_history/current.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/root/version_history/current.rst b/docs/root/version_history/current.rst index 5b5e92fea1abe..53484284e0170 100644 --- a/docs/root/version_history/current.rst +++ b/docs/root/version_history/current.rst @@ -14,6 +14,7 @@ Bug Fixes *Changes expected to improve the state of the world and are unlikely to have negative effects* * listener: fix a crash when updating any listener that does not bind to port. +* Remove redundant Warn log in HTTP codec. (#18699) Removed Config or Runtime ------------------------- From ff419175f92b080f71f480a047010c4343f09f1c Mon Sep 17 00:00:00 2001 From: Abhay Narayan Katare Date: Wed, 27 Oct 2021 22:42:13 +0530 Subject: [PATCH 3/4] fix build issues Signed-off-by: Abhay Narayan Katare --- docs/root/version_history/current.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/root/version_history/current.rst b/docs/root/version_history/current.rst index 53484284e0170..f44839c75bdeb 100644 --- a/docs/root/version_history/current.rst +++ b/docs/root/version_history/current.rst @@ -13,8 +13,8 @@ Bug Fixes --------- *Changes expected to improve the state of the world and are unlikely to have negative effects* +* http codec: remove redundant Warn log in HTTP codec. * listener: fix a crash when updating any listener that does not bind to port. -* Remove redundant Warn log in HTTP codec. (#18699) Removed Config or Runtime ------------------------- From a91af21956609c7d04b7e220a8bb1e61e0a9bd2a Mon Sep 17 00:00:00 2001 From: Abhay Narayan Katare Date: Fri, 29 Oct 2021 13:46:19 +0530 Subject: [PATCH 4/4] =?UTF-8?q?=C3=AFncorporating=20review=20comments=20by?= =?UTF-8?q?=20htuch=20on=20doc?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Abhay Narayan Katare --- docs/root/version_history/current.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/root/version_history/current.rst b/docs/root/version_history/current.rst index f44839c75bdeb..cee078a3552e9 100644 --- a/docs/root/version_history/current.rst +++ b/docs/root/version_history/current.rst @@ -13,7 +13,7 @@ Bug Fixes --------- *Changes expected to improve the state of the world and are unlikely to have negative effects* -* http codec: remove redundant Warn log in HTTP codec. +* http: remove redundant Warn log in HTTP codec. * listener: fix a crash when updating any listener that does not bind to port. Removed Config or Runtime