From 04f283529b050cbbd01d3f6ac1cd89a9f36941a1 Mon Sep 17 00:00:00 2001 From: Long Dai Date: Tue, 18 May 2021 13:18:34 +0800 Subject: [PATCH 1/4] DEVELOPER.md: add link to vscode docs Signed-off-by: Long Dai --- DEVELOPER.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/DEVELOPER.md b/DEVELOPER.md index 7a4ec69f54c6b..59fbb9e1786c5 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -9,6 +9,8 @@ To generate a coverage report, there is a [coverage build script](https://github If you plan to contribute to Envoy, you may find it useful to install the Envoy [development support toolchain](https://github.com/envoyproxy/envoy/blob/main/support/README.md), which helps automate parts of the development process, particularly those involving code review. +If you want to setup local development environment with Visual Studio Code, please follow with [vscode setup](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md). + Below is a list of additional documentation to aid the development process: - [General build and installation documentation](https://www.envoyproxy.io/docs/envoy/latest/start/start) From 51693261090a39c8120ab07e86a0a7d985d0ddd2 Mon Sep 17 00:00:00 2001 From: Long Dai Date: Tue, 18 May 2021 13:39:47 +0800 Subject: [PATCH 2/4] feedback Signed-off-by: Long Dai --- DEVELOPER.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DEVELOPER.md b/DEVELOPER.md index 59fbb9e1786c5..3b133c5756ca5 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -9,7 +9,7 @@ To generate a coverage report, there is a [coverage build script](https://github If you plan to contribute to Envoy, you may find it useful to install the Envoy [development support toolchain](https://github.com/envoyproxy/envoy/blob/main/support/README.md), which helps automate parts of the development process, particularly those involving code review. -If you want to setup local development environment with Visual Studio Code, please follow with [vscode setup](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md). +If you want to set up a local development environment with Visual Studio Code, please follow with [vscode setup](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md). Below is a list of additional documentation to aid the development process: From 7b3c550ed2e889efe07ee21b8f0275cc360fa29d Mon Sep 17 00:00:00 2001 From: Long Dai Date: Wed, 19 May 2021 16:23:10 +0800 Subject: [PATCH 3/4] feedback Signed-off-by: Long Dai --- DEVELOPER.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DEVELOPER.md b/DEVELOPER.md index 3b133c5756ca5..63f2dae19ce5b 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -9,7 +9,7 @@ To generate a coverage report, there is a [coverage build script](https://github If you plan to contribute to Envoy, you may find it useful to install the Envoy [development support toolchain](https://github.com/envoyproxy/envoy/blob/main/support/README.md), which helps automate parts of the development process, particularly those involving code review. -If you want to set up a local development environment with Visual Studio Code, please follow with [vscode setup](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md). +If you want to set up a local development environment with Visual Studio Code, please see [vscode setup](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md). Below is a list of additional documentation to aid the development process: From e0d22a16cfd1220f63b2d951b30b80de9e74794e Mon Sep 17 00:00:00 2001 From: Long Dai Date: Tue, 25 May 2021 01:11:58 -0700 Subject: [PATCH 4/4] feedback Signed-off-by: Long Dai --- DEVELOPER.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/DEVELOPER.md b/DEVELOPER.md index 63f2dae19ce5b..1fa2c5076de44 100644 --- a/DEVELOPER.md +++ b/DEVELOPER.md @@ -9,8 +9,6 @@ To generate a coverage report, there is a [coverage build script](https://github If you plan to contribute to Envoy, you may find it useful to install the Envoy [development support toolchain](https://github.com/envoyproxy/envoy/blob/main/support/README.md), which helps automate parts of the development process, particularly those involving code review. -If you want to set up a local development environment with Visual Studio Code, please see [vscode setup](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md). - Below is a list of additional documentation to aid the development process: - [General build and installation documentation](https://www.envoyproxy.io/docs/envoy/latest/start/start) @@ -21,6 +19,8 @@ Below is a list of additional documentation to aid the development process: - [Guide to Envoy Bazel rules (managing `BUILD` files)](https://github.com/envoyproxy/envoy/blob/main/bazel/DEVELOPER.md) +- [Guide to setup development environment with Visual Studio Code](https://github.com/envoyproxy/envoy/blob/main/tools/vscode/README.md) + - [Using Docker for building and testing](https://github.com/envoyproxy/envoy/tree/main/ci) - [Guide to contributing to Envoy](https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md)