diff --git a/bazel/repositories.bzl b/bazel/repositories.bzl index c143dc01c3e7b..6a4730ac44a98 100644 --- a/bazel/repositories.bzl +++ b/bazel/repositories.bzl @@ -356,6 +356,9 @@ def _com_github_zlib_ng_zlib_ng(): patches = ["@envoy//bazel/foreign_cc:zlib_ng.patch"], ) +# If you're looking for envoy-filter-example / envoy_filter_example +# the hash is in ci/filter_example_setup.sh + def _org_brotli(): external_http_archive( name = "org_brotli", diff --git a/ci/filter_example_setup.sh b/ci/filter_example_setup.sh index c3926e5d2c7a5..4fef840e0389d 100644 --- a/ci/filter_example_setup.sh +++ b/ci/filter_example_setup.sh @@ -5,7 +5,7 @@ set -e # This is the hash on https://github.com/envoyproxy/envoy-filter-example.git we pin to. -ENVOY_FILTER_EXAMPLE_GITSHA="8f0f8bba38868e875613b74f57df38f543e764ba" +ENVOY_FILTER_EXAMPLE_GITSHA="d135632a6e96268ab2c6a62e1cceec25c728ccf9" ENVOY_FILTER_EXAMPLE_SRCDIR="${BUILD_DIR}/envoy-filter-example" # shellcheck disable=SC2034 diff --git a/test/extensions/filters/http/composite/composite_filter_integration_test.cc b/test/extensions/filters/http/composite/composite_filter_integration_test.cc index da206d4ecb0f0..8a290b633f963 100644 --- a/test/extensions/filters/http/composite/composite_filter_integration_test.cc +++ b/test/extensions/filters/http/composite/composite_filter_integration_test.cc @@ -62,7 +62,7 @@ TEST_P(CompositeFilterIntegrationTest, TestBasic) { waitForNextUpstreamRequest(); upstream_request_->encodeHeaders(Http::TestResponseHeaderMapImpl{{":status", "200"}}, true); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); EXPECT_THAT(response->headers(), Http::HttpStatusIs("200")); } @@ -73,7 +73,7 @@ TEST_P(CompositeFilterIntegrationTest, TestBasic) { {"match-header", "match"}, {":authority", "blah"}}; auto response = codec_client_->makeRequestWithBody(request_headers, 1024); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); EXPECT_THAT(response->headers(), Http::HttpStatusIs("403")); } } diff --git a/test/integration/extension_discovery_integration_test.cc b/test/integration/extension_discovery_integration_test.cc index e4e0d6d8885b5..8d8271a21f89c 100644 --- a/test/integration/extension_discovery_integration_test.cc +++ b/test/integration/extension_discovery_integration_test.cc @@ -333,7 +333,7 @@ TEST_P(ExtensionDiscoveryIntegrationTest, BasicSuccessWithTtl) { Http::TestRequestHeaderMapImpl request_headers{ {":method", "GET"}, {":path", "/"}, {":scheme", "http"}, {":authority", "host"}}; auto response = codec_client_->makeHeaderOnlyRequest(request_headers); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); ASSERT_TRUE(response->complete()); EXPECT_EQ("200", response->headers().getStatusValue()); } @@ -341,7 +341,7 @@ TEST_P(ExtensionDiscoveryIntegrationTest, BasicSuccessWithTtl) { {":method", "GET"}, {":path", "/private/key"}, {":scheme", "http"}, {":authority", "host"}}; { auto response = codec_client_->makeHeaderOnlyRequest(banned_request_headers); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); ASSERT_TRUE(response->complete()); EXPECT_EQ("403", response->headers().getStatusValue()); } @@ -352,7 +352,7 @@ TEST_P(ExtensionDiscoveryIntegrationTest, BasicSuccessWithTtl) { test_server_->waitForCounterGe("http.config_test.extension_config_discovery.foo.config_reload", 2); auto response = codec_client_->makeHeaderOnlyRequest(banned_request_headers); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); ASSERT_TRUE(response->complete()); EXPECT_EQ("500", response->headers().getStatusValue()); } @@ -364,7 +364,7 @@ TEST_P(ExtensionDiscoveryIntegrationTest, BasicSuccessWithTtl) { test_server_->waitForCounterGe("http.config_test.extension_config_discovery.foo.config_reload", 3); auto response = codec_client_->makeHeaderOnlyRequest(banned_request_headers); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); ASSERT_TRUE(response->complete()); EXPECT_EQ("403", response->headers().getStatusValue()); } @@ -389,7 +389,7 @@ TEST_P(ExtensionDiscoveryIntegrationTest, BasicSuccessWithTtlWithDefault) { {":method", "GET"}, {":path", "/private/key"}, {":scheme", "http"}, {":authority", "host"}}; { auto response = codec_client_->makeHeaderOnlyRequest(banned_request_headers); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); ASSERT_TRUE(response->complete()); EXPECT_EQ("200", response->headers().getStatusValue()); } @@ -400,7 +400,7 @@ TEST_P(ExtensionDiscoveryIntegrationTest, BasicSuccessWithTtlWithDefault) { test_server_->waitForCounterGe("http.config_test.extension_config_discovery.foo.config_reload", 2); auto response = codec_client_->makeHeaderOnlyRequest(banned_request_headers); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); ASSERT_TRUE(response->complete()); EXPECT_EQ("403", response->headers().getStatusValue()); } diff --git a/test/integration/integration_stream_decoder.h b/test/integration/integration_stream_decoder.h index 06697260ec034..6f706c663267f 100644 --- a/test/integration/integration_stream_decoder.h +++ b/test/integration/integration_stream_decoder.h @@ -40,7 +40,7 @@ class IntegrationStreamDecoder : public Http::ResponseDecoder, public Http::Stre // can be used if the previous body data is not relevant and the test wants to wait for a specific // amount of new data without considering the existing body size. void waitForBodyData(uint64_t size); - testing::AssertionResult + ABSL_MUST_USE_RESULT testing::AssertionResult waitForEndStream(std::chrono::milliseconds timeout = TestUtility::DefaultTimeout); ABSL_MUST_USE_RESULT testing::AssertionResult waitForReset(std::chrono::milliseconds timeout = TestUtility::DefaultTimeout); diff --git a/test/integration/quic_http_integration_test.cc b/test/integration/quic_http_integration_test.cc index 65352aea97969..33671493049e1 100644 --- a/test/integration/quic_http_integration_test.cc +++ b/test/integration/quic_http_integration_test.cc @@ -558,7 +558,7 @@ TEST_P(QuicHttpIntegrationTest, ResetRequestWithoutAuthorityHeader) { request_encoder_ = &encoder_decoder.first; auto response = std::move(encoder_decoder.second); - response->waitForEndStream(); + ASSERT_TRUE(response->waitForEndStream()); codec_client_->close(); ASSERT_TRUE(response->complete()); EXPECT_EQ("400", response->headers().getStatusValue());