You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.
Title: printing non-utf8 string from metadata crashes Envoy (when trace enabled)
Description:
envoy/http/metadata_interface.h seems assume that metadata K:V are in utf8 strings:
But seems no such constraint in spec for metadata.
We should at least eacape the K:V before passing them into spdglog which expects utf8 string.
https://github.com/abseil/abseil-cpp/blob/master/absl/strings/escaping.h
Repro steps:
Envoy will crash when the serializeAsString() contains invalid utf8 string, while spdlog tries to interpret the value as an utf8 string.
The text was updated successfully, but these errors were encountered: