Skip to content

Commit d828958

Browse files
authored
build: Remove chromium_url (#12023)
This removes chromium_url in favor of GURL. Risk Level: Low Testing: Existing tests Docs Changes: N/A Release Notes: N/A Fixes: #6588 Signed-off-by: Dhi Aurrahman <[email protected]>
1 parent 706d976 commit d828958

17 files changed

+12
-1377
lines changed

.bazelrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ build:coverage --strategy=CoverageReport=sandboxed,local
128128
build:coverage --experimental_use_llvm_covmap
129129
build:coverage --collect_code_coverage
130130
build:coverage --test_tag_filters=-nocoverage
131-
build:coverage --instrumentation_filter="//source(?!/common/chromium_url|/extensions/quic_listeners/quiche/platform)[/:],//include[/:]"
131+
build:coverage --instrumentation_filter="//source(?!/extensions/quic_listeners/quiche/platform)[/:],//include[/:]"
132132
coverage:test-coverage --test_arg="-l trace"
133133
coverage:fuzz-coverage --config=asan-fuzzer
134134
coverage:fuzz-coverage --run_under=@envoy//bazel/coverage:fuzz_coverage_wrapper.sh

ci/run_clang_tidy.sh

+1-7
Original file line numberDiff line numberDiff line change
@@ -50,19 +50,13 @@ function exclude_testdata() {
5050
grep -v tools/testdata/check_format/
5151
}
5252

53-
# Do not run clang-tidy against Chromium URL import, this needs to largely
54-
# reflect the upstream structure.
55-
function exclude_chromium_url() {
56-
grep -v source/common/chromium_url/
57-
}
58-
5953
# Exclude files in third_party which are temporary forks from other OSS projects.
6054
function exclude_third_party() {
6155
grep -v third_party/
6256
}
6357

6458
function filter_excludes() {
65-
exclude_testdata | exclude_chromium_url | exclude_win32_impl | exclude_macos_impl | exclude_third_party
59+
exclude_testdata | exclude_win32_impl | exclude_macos_impl | exclude_third_party
6660
}
6761

6862
if [[ -z "${DIFF_REF}" && "${BUILD_REASON}" != "PullRequest" ]]; then

source/common/chromium_url/BUILD

-28
This file was deleted.

source/common/chromium_url/LICENSE

-27
This file was deleted.

source/common/chromium_url/README.md

-16
This file was deleted.

source/common/chromium_url/envoy_shim.h

-17
This file was deleted.

source/common/chromium_url/url_canon.cc

-16
This file was deleted.

source/common/chromium_url/url_canon.h

-186
This file was deleted.

0 commit comments

Comments
 (0)