Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use core::num::NonZero where CT is not relevant #56

Closed
dvdplm opened this issue Oct 9, 2024 · 0 comments · Fixed by #63
Closed

Use core::num::NonZero where CT is not relevant #56

dvdplm opened this issue Oct 9, 2024 · 0 comments · Fixed by #63
Labels
enhancement New feature or request

Comments

@dvdplm
Copy link
Contributor

dvdplm commented Oct 9, 2024

For variable time code, using core::num::NonZero<T> may be more performant than crypto-bigint::NonZero<T>. However, the stdlib version relies on the (perma-?)unstable trait ZeroablePrimitive, which means that we are restricted to Ts from Rust's standard numeric types. :/

See the FCP comment for some more details on what was recently stabilized and what was not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants