Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yeoman init output #89

Closed
addyosmani opened this issue Oct 10, 2012 · 1 comment · May be fixed by enterstudio/generator#14
Closed

yeoman init output #89

addyosmani opened this issue Oct 10, 2012 · 1 comment · May be fixed by enterstudio/generator#14

Comments

@addyosmani
Copy link
Member

From yeoman/yeoman#567

as you know, yeoman init executes a generator-- even if no generator is specified the result of yeoman init is really yeoman init yeoman:app.

the initial text output by yeoman init comes from the yeoman init grunt task not the generator that's ultimately used, which would be fine if it was a single line informing the user that yeoman is about to do whatever it was asked to do but it's not, it's 21 lines of text that (more than likely) doesn't apply to the generator you're about to run.

it tells me it's going to ask some questions and instructions how to answer them when my task may or may not ask any questions at all; then after a bunch of blank lines and ascii art, it informs me HTML5 Boilerplate, jQuery and Modernizr are included (again possibly having nothing to do with the ultimate task)

all this pre-generator output seems to jive with what yeoman init does with no arguments so i propose moving all that to the yeoman:app generator and replacing it with something short(er) and generator agnostic.

lastly, to illustrate my point open the terminal and run yeoman init with an invalid or misspelled generator name i.e. yeoman init icantspell ... the error message the user cares about is in there somewhere.
@addyosmani addyosmani mentioned this issue Oct 10, 2012
Closed
@btford
Copy link
Contributor

btford commented Oct 10, 2012

Thanks for making the issue, Addy.

Here's what yeoman init currently looks like:

Running "init:yeoman" (init) task
This task will create one or more files in the current directory, based on the
environment and the answers to a few questions. Note that answering "?" to any
question will show question-specific help and answering "none" to most questions
will leave its value blank.

"yeoman" template notes:



     _-----_
    |       |
    |--(o)--|   .--------------------------.
   `---------´  |    Welcome to Yeoman,    |
    ( _´U`_ )   |   ladies and gentlemen!  |
    /___A___\   '__________________________'
     |  ~  |
   __'.___.'__
 ´   `  |° ´ Y `

Out of the box I include HTML5 Boilerplate, jQuery and Modernizr.

   invoke  app

Please answer the following:

 Would you like to include Twitter Bootstrap for Compass? (Y/n) y

 Would you like to include the Twitter Bootstrap plugins? (Y/n) y

...

Here's how I think we should expect yeoman init to look:

Out of the box I include HTML5 Boilerplate, jQuery and Modernizr.

Please answer the following:

 Would you like to include Twitter Bootstrap for Compass? (Y/n) y

 Would you like to include the Twitter Bootstrap plugins? (Y/n) y

...

I don't think the ASCII art is useful, and I don't think we need to explain upfront that this is going to "create one or more files in the current directory, based on the environment and the answers to a few questions" (a user can ask for more info with --help).

Note that answering "?" to any question will show question-specific help and answering "none" to most questions will leave its value blank.

Is this still true? I can't find an example of this working.

btford added a commit to btford/generators that referenced this issue Oct 10, 2012
@btford
Move the ascii art and explanation to yeoman:app. Addresses issue yeo…
e894d2d 
…man#89
addyosmani added a commit that referenced this issue Oct 12, 2012
@addyosmani
Merge pull request #92 from btford/less-verbose-init
f5b38bb 
Move the ascii art and explanation to yeoman:app. Addresses issue #89
@enterstudio enterstudio mentioned this issue May 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 1 vulnerabilities enterstudio/generator
3 participants
@addyosmani @sindresorhus @btford