Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store should use window.localStorage instead of global window namespace #2610

Open
alansemenov opened this issue Jun 3, 2022 · 0 comments
Open

Store should use window.localStorage instead of global window namespace #2610

alansemenov opened this issue Jun 3, 2022 · 0 comments
Labels
Improvement Suggestion for improvement

Comments

@alansemenov
Copy link
Member

alansemenov commented Jun 3, 2022 •
edited
Loading

lib-admin-ui creates an object (window.libAdmin) in the global window namespace to share data between the apps. This should be done via window.localStorage. Also check if all of the properties we store there are really needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Suggestion for improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alansemenov