Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hidden desktop files do not participate in desktop ID precedence rules #167

Closed
Nycta-b424b3c7 opened this issue Jun 23, 2024 · 4 comments
Closed
Milestone

Comments

@Nycta-b424b3c7
Copy link

I override desktop files in ~/.local/share/applications, to hide those that I don't want to be shown (Such as xfce4-about.desktop that shows "About Xfce" window, for instance).

The program seem to explicitly ignore those (I saw Desktop file is skipped: Refusing to parse Hidden or NoDisplay desktop file. in logs).

Can you please make this use-case viable?

@meator
Copy link
Collaborator

meator commented Jun 23, 2024

Thanks for the bug report!

Sorry, I haven't considered your use case. I have even written an unit test that verifies that this arguably incorrect behavior is in place. j4-dmenu-desktop r3.0 completely ignores hidden files, which is different from the behavior of r2.18.

This will be fixed in the r3.1 release.

@meator meator added this to the r3.1 milestone Jun 23, 2024
@Nycta-b424b3c7
Copy link
Author

That's awesome, thank you very much!

@meator meator closed this as completed in 957e98e Jun 24, 2024
@meator
Copy link
Collaborator

meator commented Jun 24, 2024

Should be fixed in develop. Could you please verify that the issue is fixed? You can clone this repository and follow build requirements to build the latest j4-dmenu-destkop.

@Nycta-b424b3c7
Copy link
Author

Built it from develop sources and it sure does work! Thank you very much!

@meator meator changed the title Desktop files with 'Hidden=true' are still shown Hidden desktop files do not participate in desktop ID precedence rules Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants