Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Catch #142

Closed
meator opened this issue Sep 1, 2023 · 1 comment
Closed

Upgrade Catch #142

meator opened this issue Sep 1, 2023 · 1 comment
Assignees
@meator
Milestone
r3.0

Comments

@meator
Copy link
Collaborator

meator commented Sep 1, 2023

Catch1.x is ancient now. I propose upgrading straight to Catch2 v3 (I know, really bad naming, should have been Catch3). The new version is no longer header only which means faster (re)compile times (allegedly, I think it's still pretty slow but haven't measured it). Using the newest Catch also means that j4dd would be working with actively supported library with newer features (realistically assert() of Catch2's REQUIRE() is all one would need but still). I have experience with the latest Catch so I will handle tests.
@meator meator added this to the r3.0 milestone Sep 1, 2023
@meator meator self-assigned this Sep 1, 2023
@meator
Copy link
Collaborator Author

meator commented Sep 2, 2023

Also CMakeLists.txt has a section for detecting system installed Catch. I don't think any distro packages Catch1 nowdays so this detection doesn't have much use. The whole logic in CMakeLists.txt is questionable to me but I don't have much experience with CMake.

@meator meator mentioned this issue Oct 8, 2023
Closed
@meator meator closed this as completed in 2690658 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meator meator

Labels
None yet
Projects
None yet
Milestone
r3.0
Development

No branches or pull requests
1 participant
@meator