commit 0db350699 breaks --with-sdcard build for upstream LiteX
#540
Comments
|
In enjoy-digital/litesdcard#7 we extended the LiteSDCard core so it's fully usable in Linux (https://github.com/litex-hub/linux-on-litex-vexriscv/blob/master/soc_linux.py#L236). As a part of this work we extended LiteX BIOS sdcard testing capabilities by adding tests for reading/writing actual data. They require additional memory regions (buffers) - It looks we missed the It requires to extend the Once it's confirmed to work fine, we'll PR the fix to the mainline LiteX. |
|
@mateusz-holenko : thanks, the patch does indeed fix the compilation error. However, testing (from the bios prompt) fails: after (successfully) completing After that, trying to read the data back fails: This happens both with the 64GB SanDisk card that used to work pre-0db350699 (and LiteSDCard commit da5467b), and with the 32GB SanDisk that didn't work even before the latest changes. The ad infinitum... Also, a somewhat related question: if not the nexys4ddr, which board did you use to test? |
|
We'll grab some As for the HW we developed and tested the litesdcard core on, it was: |
|
@mateusz-holenko: thanks for ordering a |
|
It took less time than I thought (turns out I'm a pessimist). @enjoy-digital we had some HW in the office, but due to the current situation (working from home) I expected this to be more problematic than it really was. Anyway, we were able to test it on HW and prepared another fix: https://github.com/antmicro/litex/tree/nexys4ddr-sdcard. It works for us, but could you give it a try, @gsomlo? That's our output: |
|
@mateusz-holenko: thanks, i'll also test it on hardware. BTW as some point we should probably rework/simplify the LiteSDCard interface/integration but for now it's probably better to get everything working with Linux, we could do this work later when we'll have a reference implementation (i could do it). |
|
@mateusz-holenko: i can confirm this is working on Nexys4DDR. I tested with several SDCards and updated the target: 2efcf87, thanks. Let's wait the results from @gsomlo to close this. |
|
@enjoy-digital @mateusz-holenko : thanks, 2efcf87 fixed it for me as well (vexriscv, 8-bit CSRs). (next on the agenda, I'll try getting it to work on rocket and/or with 32-bit CSRs, and send a PR about that :) ). |
|
hmmm... Although hardcoding is not very portable, as it overlaps with |
|
@gsomlo: yes we should change that, i just reused un-modified example to be sure it was working. I can have a look. |
|
@enjoy-digital If you're going to post a fixup patch, please also |
Actually, nvm that, it's a bit more involved than just that :) Please see PR #542 instead. |
That's correct. |
|
@mateusz-holenko: ok thanks, i did the changes to use dynamic mapping for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Attempting to build LiteX with
--with-sdcard(on the nexys4ddr) fails:results in
error: 'SDREAD_BASE' undeclaredand'SDWRITE_BASE' undeclaredhere:https://github.com/enjoy-digital/litex/blob/master/litex/soc/software/liblitesdcard/sdcard.c#L39
Those two constants were introduced by commit 0db3506 ("Update Litex bios to handle updated litesdcard."). I can only assume they're present in some downstream (Antmicro?) version of LiteX, and build fine there.
Anything I'm missing? @mateusz-holenko @kamilrakoczy -- anything that should have been part of that commit and somehow fell through the cracks?
The text was updated successfully, but these errors were encountered: