litesdcard: fix handling LONG responses #7
Conversation
|
CC @kgugala |
|
for one thing, this patch removes |
|
@gsomlo: indeed, i was also going to ask that to be able to be able to test the changes. |
|
the clocker and I did try the |
|
Thanks for the info - we'll rebase this and verify how it works against the current upstream. |
|
@gsomlo, @mateusz-holenko: for info, i merged manually the With the changes already merged, i've been able to get the sdcard tests working: But not with the changes in core.py. I was planning to investigate on that today. |
Setting sink.data size to 16 bytes results in missing 2 bytes in LONG response.
mateusz-holenko
force-pushed
the
sdcard-fixes
branch
from
8908aa4 to
ada2405
Compare
|
We rebased our changes on top of the current master and split it into two separate commits to make debugging/merging easier.
@enjoy-digital What problems did you encounter? |
|
@mateusz-holenko: the SDCard was not initializing correctly. I'll test your updated PR in the afternoon. |
|
@enjoy-digital - what are you testing it on? We had to introduce some changes to LiteX (including BIOS) in order to make it work. Currently they are available on the branch antmicro/litex@179b725, but once we clean them up we are planning to create a PR to mainline. |
|
I'm testing on the Nexys4DDR. I'll look at your changes. |
|
@enjoy-digital Can we help you somehow with testing the changes? |
|
@mateusz-holenko: sorry i forgot to test it. I'll do that today. |
|
@enjoy-digital did you have time to review this? This is slowly becoming a blocker for us |
|
@kgugala: sorry, i'm going to test. |
|
@mateusz-holenko, @kgugala: i've been trying to test the code but i'm having trouble reproducing my previous results. Can you tell me how you are testing it? We could merge if this is blocking you, but i 'd like to able to reproduce your results to look at the code that is now commented. |
|
@enjoy-digital: We test it on arty A7 using the modified LiteX BIOS (antmicro/litex@179b725) using the following commands: The initialization of the SD Card works for us and we get the following output: |
|
@enjoy-digital - as @kgugala mentioned this becomes a blocker for us. Would it be possible for you to merge this and we will continue the discussion/testing in the meantime? |
|
I've been able to test it successfully on the Nexys4DDR by integrating your gateware and software changes. So we can merge it. Could you do a PR to LiteX with the software changes once you think it's ready? |
|
That's great, thanks! Yes, I'll now work on a PR to LiteX. |
This also disables CRC checks as they fail for some commands. This must be investigated further.
This will be followed by two more PRs: