Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CRC check on cmd/data responses #15

Open
enjoy-digital opened this issue Jun 3, 2020 · 1 comment
Open

Enable CRC check on cmd/data responses #15

enjoy-digital opened this issue Jun 3, 2020 · 1 comment

Comments

@enjoy-digital
Copy link
Owner

CRC check on responses has been disabled as part of #7. We need to understand why this was needed and only disable it on the commands that are not returning a CRC.

@enjoy-digital enjoy-digital changed the title Re-enable CRC check on responses Enable CRC check on cmd/data responses Aug 26, 2020
@paulusmack
Copy link
Contributor

Response types R2 and R3 don't contain a CRC, so commands 2, 9, 10 and app cmd 41 won't have a CRC in the response.

The Linux MMC layer uses the MMC_RSP_CRC bit in cmd->flags to indicate whether the response has a CRC, so the low-level driver doesn't need to know.

I'll have a look at adding a bit to the CMDCMD register to indicate whether the response CRC should be checked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants