From 275fb0286ce00c14a78b8f36ad49d11071c2555c Mon Sep 17 00:00:00 2001 From: Jason Simmons Date: Fri, 13 May 2022 12:57:59 -0700 Subject: [PATCH] Fix avoid_redundant_argument_values analyzer warnings enabled in the latest Dart SDK (#103734) See https://github.com/flutter/flutter/pull/103719 --- .../flutter_gallery/lib/demo/material/leave_behind_demo.dart | 1 - packages/flutter/lib/src/foundation/_isolates_io.dart | 1 - packages/flutter/lib/src/services/system_chrome.dart | 2 -- packages/flutter/lib/src/widgets/navigator.dart | 2 +- packages/flutter/test/cupertino/route_test.dart | 1 - packages/flutter/test/material/bottom_sheet_test.dart | 4 ---- packages/flutter/test/material/dialog_test.dart | 1 - packages/flutter/test/widgets/routes_test.dart | 3 --- packages/flutter_tools/lib/src/android/android_workflow.dart | 4 ++-- packages/flutter_tools/lib/src/base/process.dart | 4 ++-- .../flutter_web_plugins/test/plugin_event_channel_test.dart | 4 ++-- packages/integration_test/lib/_callback_io.dart | 2 -- 12 files changed, 7 insertions(+), 22 deletions(-) diff --git a/dev/integration_tests/flutter_gallery/lib/demo/material/leave_behind_demo.dart b/dev/integration_tests/flutter_gallery/lib/demo/material/leave_behind_demo.dart index b622c633269b..ccee4e1d8482 100644 --- a/dev/integration_tests/flutter_gallery/lib/demo/material/leave_behind_demo.dart +++ b/dev/integration_tests/flutter_gallery/lib/demo/material/leave_behind_demo.dart @@ -275,7 +275,6 @@ class _LeaveBehindListItem extends StatelessWidget { Future _showConfirmationDialog(BuildContext context, String action) { return showDialog( context: context, - barrierDismissible: true, builder: (BuildContext context) { return AlertDialog( title: Text('Do you want to $action this item?'), diff --git a/packages/flutter/lib/src/foundation/_isolates_io.dart b/packages/flutter/lib/src/foundation/_isolates_io.dart index ab0b0ce1ca7c..9b5386fd45ae 100644 --- a/packages/flutter/lib/src/foundation/_isolates_io.dart +++ b/packages/flutter/lib/src/foundation/_isolates_io.dart @@ -41,7 +41,6 @@ Future compute(isolates.ComputeCallback callback, Q message, { St debugLabel, flow.id, ), - errorsAreFatal: true, onExit: port.sendPort, onError: port.sendPort, debugName: debugLabel, diff --git a/packages/flutter/lib/src/services/system_chrome.dart b/packages/flutter/lib/src/services/system_chrome.dart index 66d1c03c6c52..002c768cb594 100644 --- a/packages/flutter/lib/src/services/system_chrome.dart +++ b/packages/flutter/lib/src/services/system_chrome.dart @@ -500,7 +500,6 @@ class SystemChrome { if (callback != null) { await SystemChannels.platform.invokeMethod( 'SystemChrome.setSystemUIChangeListener', - null, ); } } @@ -517,7 +516,6 @@ class SystemChrome { static Future restoreSystemUIOverlays() async { await SystemChannels.platform.invokeMethod( 'SystemChrome.restoreSystemUIOverlays', - null, ); } diff --git a/packages/flutter/lib/src/widgets/navigator.dart b/packages/flutter/lib/src/widgets/navigator.dart index c64eac58cc67..f9c8245f833d 100644 --- a/packages/flutter/lib/src/widgets/navigator.dart +++ b/packages/flutter/lib/src/widgets/navigator.dart @@ -5268,7 +5268,7 @@ class _NamedRestorationInformation extends _RestorationInformation { @override Route createRoute(NavigatorState navigator) { - final Route route = navigator._routeNamed(name, arguments: arguments, allowNull: false)!; + final Route route = navigator._routeNamed(name, arguments: arguments)!; assert(route != null); return route; } diff --git a/packages/flutter/test/cupertino/route_test.dart b/packages/flutter/test/cupertino/route_test.dart index a48bbe453d1f..a60a7b6c12f0 100644 --- a/packages/flutter/test/cupertino/route_test.dart +++ b/packages/flutter/test/cupertino/route_test.dart @@ -1635,7 +1635,6 @@ void main() { await showCupertinoModalPopup( context: context, builder: (BuildContext context) => const Text('Visible'), - barrierDismissible: true, ); }, child: const Text('tap'), diff --git a/packages/flutter/test/material/bottom_sheet_test.dart b/packages/flutter/test/material/bottom_sheet_test.dart index 5b2bd8fcac41..debb437d953a 100644 --- a/packages/flutter/test/material/bottom_sheet_test.dart +++ b/packages/flutter/test/material/bottom_sheet_test.dart @@ -218,7 +218,6 @@ void main() { showModalBottomSheet( context: savedContext, isDismissible: false, - enableDrag: true, builder: (BuildContext context) { numBuilderCalls++; return const Text('BottomSheet'); @@ -323,7 +322,6 @@ void main() { showModalBottomSheet( context: savedContext, builder: (BuildContext context) => const Text('BottomSheet'), - isDismissible: true, ).then((void value) { showBottomSheetThenCalled = true; }); @@ -498,7 +496,6 @@ void main() { showModalBottomSheet( context: savedContext, isDismissible: false, - enableDrag: true, builder: (BuildContext context) => const Text('BottomSheet'), ).then((void value) { showBottomSheetThenCalled = true; @@ -531,7 +528,6 @@ void main() { showModalBottomSheet( context: savedContext, isDismissible: false, - enableDrag: true, builder: (BuildContext context) { numBuilderCalls++; return const Text('BottomSheet'); diff --git a/packages/flutter/test/material/dialog_test.dart b/packages/flutter/test/material/dialog_test.dart index 9645c510ac70..14c821b775a5 100644 --- a/packages/flutter/test/material/dialog_test.dart +++ b/packages/flutter/test/material/dialog_test.dart @@ -1648,7 +1648,6 @@ void main() { Future confirmDismiss (DismissDirection dismissDirection) async { return showDialog( context: scaffoldKey.currentContext!, - barrierDismissible: true, // showDialog() returns null if tapped outside the dialog builder: (BuildContext context) { return AlertDialog( actions: [ diff --git a/packages/flutter/test/widgets/routes_test.dart b/packages/flutter/test/widgets/routes_test.dart index 3178857942e5..ad36da4356dc 100644 --- a/packages/flutter/test/widgets/routes_test.dart +++ b/packages/flutter/test/widgets/routes_test.dart @@ -1019,7 +1019,6 @@ void main() { onPressed: () { showGeneralDialog( context: context, - barrierDismissible: false, transitionDuration: Duration.zero, pageBuilder: (BuildContext innerContext, _, __) { return const SizedBox(); @@ -1097,7 +1096,6 @@ void main() { onPressed: () { showGeneralDialog( context: context, - barrierDismissible: false, transitionDuration: Duration.zero, pageBuilder: (BuildContext innerContext, _, __) { return const SizedBox(); @@ -1135,7 +1133,6 @@ void main() { showGeneralDialog( useRootNavigator: false, context: context, - barrierDismissible: false, transitionDuration: Duration.zero, pageBuilder: (BuildContext innerContext, _, __) { return const SizedBox(); diff --git a/packages/flutter_tools/lib/src/android/android_workflow.dart b/packages/flutter_tools/lib/src/android/android_workflow.dart index 26b9af006e6c..675b47350858 100644 --- a/packages/flutter_tools/lib/src/android/android_workflow.dart +++ b/packages/flutter_tools/lib/src/android/android_workflow.dart @@ -402,12 +402,12 @@ class AndroidLicenseValidator extends DoctorValidator { .transform(const Utf8Decoder(reportErrors: false)) .transform(const LineSplitter()) .listen(handleLine) - .asFuture(null); + .asFuture(); final Future errors = process.stderr .transform(const Utf8Decoder(reportErrors: false)) .transform(const LineSplitter()) .listen(handleLine) - .asFuture(null); + .asFuture(); await Future.wait(>[output, errors]); return status ?? LicensesAccepted.unknown; } on ProcessException catch (e) { diff --git a/packages/flutter_tools/lib/src/base/process.dart b/packages/flutter_tools/lib/src/base/process.dart index 1496a5d40b23..f37989fb5f37 100644 --- a/packages/flutter_tools/lib/src/base/process.dart +++ b/packages/flutter_tools/lib/src/base/process.dart @@ -295,11 +295,11 @@ class _DefaultProcessUtils implements ProcessUtils { final Future stdoutFuture = process.stdout .transform(const Utf8Decoder(reportErrors: false)) .listen(stdoutBuffer.write) - .asFuture(null); + .asFuture(); final Future stderrFuture = process.stderr .transform(const Utf8Decoder(reportErrors: false)) .listen(stderrBuffer.write) - .asFuture(null); + .asFuture(); int? exitCode; exitCode = await process.exitCode.then((int x) => x).timeout(timeout, onTimeout: () { diff --git a/packages/flutter_web_plugins/test/plugin_event_channel_test.dart b/packages/flutter_web_plugins/test/plugin_event_channel_test.dart index 7c44dcc13b94..3ff4b92d2035 100644 --- a/packages/flutter_web_plugins/test/plugin_event_channel_test.dart +++ b/packages/flutter_web_plugins/test/plugin_event_channel_test.dart @@ -93,7 +93,7 @@ void main() { PluginEventChannel('test3'); final StreamController controller = StreamController( - onListen: expectAsync0(() {}, count: 1)); + onListen: expectAsync0(() {})); sendingChannel.setController(controller); expect(listeningChannel.receiveBroadcastStream(), @@ -109,7 +109,7 @@ void main() { PluginEventChannel('test3'); final StreamController controller = StreamController( - onListen: expectAsync0(() {}, count: 1)); + onListen: expectAsync0(() {})); sendingChannel.setController(controller); expect(listeningChannel.receiveBroadcastStream(), diff --git a/packages/integration_test/lib/_callback_io.dart b/packages/integration_test/lib/_callback_io.dart index d5851eccd45a..662b6af22771 100644 --- a/packages/integration_test/lib/_callback_io.dart +++ b/packages/integration_test/lib/_callback_io.dart @@ -73,7 +73,6 @@ class IOCallbackManager implements CallbackManager { assert(!_isSurfaceRendered, 'Surface already converted to an image'); await integrationTestChannel.invokeMethod( 'convertFlutterSurfaceToImage', - null, ); _isSurfaceRendered = true; @@ -81,7 +80,6 @@ class IOCallbackManager implements CallbackManager { assert(_isSurfaceRendered, 'Surface is not an image'); await integrationTestChannel.invokeMethod( 'revertFlutterImage', - null, ); _isSurfaceRendered = false; });